Skip to content

Add explicit namespaces to the GDCLASS*, ERR_*, and WARN_* macros.#825

Closed
bruvzg wants to merge 1 commit into
godotengine:masterfrom
bruvzg:namespace
Closed

Add explicit namespaces to the GDCLASS*, ERR_*, and WARN_* macros.#825
bruvzg wants to merge 1 commit into
godotengine:masterfrom
bruvzg:namespace

Conversation

@bruvzg

@bruvzg bruvzg commented Sep 2, 2022

Copy link
Copy Markdown
Member

Fixes #821 and similar issues with ERR_ macros.

@bruvzg bruvzg added bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation labels Sep 2, 2022
@bruvzg bruvzg added this to the 4.0 milestone Sep 2, 2022
@akien-mga
akien-mga requested a review from a team September 2, 2022 07:06
@bruvzg

bruvzg commented Sep 2, 2022

Copy link
Copy Markdown
Member Author

Actually already done by #823

@bruvzg bruvzg closed this Sep 2, 2022
@bruvzg
bruvzg deleted the namespace branch September 2, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived bug This has been identified as a bug enhancement This is an enhancement on the current functionality topic:gdextension This relates to the new Godot 4 extension implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merged PR #816 force to use "using namespace godot;" in namespace where GDCLASS macro is used

2 participants