Ensure GDCLASS can be used outside the godot namespace.#823
Merged
akien-mga merged 1 commit intoSep 2, 2022
Conversation
The `GDCLASS` macro should not assume to be called inside the `godot` namespace and should thus prefix function calls for that namespace with `::godot::` to ensure proper namespace referencing.
Faless
added
bug
bruvzg
approved these changes
Sep 2, 2022
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GDCLASSmacro should not assume to be called inside thegodotnamespace and should thus prefix function calls for that namespace with::godot::to ensure proper namespace referencing.I suggest we also split the "internal" stuff (used by generated bindings) from
wrapped.hppinto a separatewrapped_internal.hppfile to further convey the idea thatGDCLASSis for users, but direct access toWrappedand theGDNATIVE_CLASSmacro are for internal use.