Fix incorrect utility call signature#1422
Merged
Merged
Conversation
AThousandShips
added
bug
AThousandShips
marked this pull request as ready for review
March 27, 2024 12:22
dsnopek
approved these changes
Apr 2, 2024
dsnopek
left a comment
dsnopek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Looks good to me :-)
Collaborator
|
Ack, there's a conflict now from merging PR #1409. Can you please rebase it? Thanks! |
AThousandShips
force-pushed
the
utility_fix
branch
from
April 2, 2024 19:45
fb2399e to
d055b57
Compare
Collaborator
|
Thanks! |
Member
Author
|
Thank you! |
Collaborator
|
Cherry-picked for 4.1 in PR #1411 |
Collaborator
|
Cherry-picked for 4.2 in PR #1410 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alternative method would be to change the bindings from:
godot-cpp/binding_generator.py
Line 2054 in a62f633
To:
But I don't see any reason to pass this argument here, and this is strictly internal, so I think this is the simplest and cleanest solution, I have tested both methods and they both work correctly
See: