Support iterable of output_entity_hints#5
Merged
Conversation
Tom-Newton
added a commit
that referenced
this pull request
Nov 17, 2023
Tom-Newton
added a commit
that referenced
this pull request
Dec 1, 2023
Tom-Newton
added a commit
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
added a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
added a commit
that referenced
this pull request
Dec 20, 2023
Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>
Tom-Newton
added a commit
that referenced
this pull request
Apr 8, 2024
* Add output_entity_hint and support for serialising it Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Correct assertion Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add output_entity_hint to task decorator Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix circular import of type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Support iterable of output_entity_hints (#5) Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix circular import for type hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix tests Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Auto-format Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add positive test case Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Add a test for disallowing entity hints on static tasks Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * raise instead of assert Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Rename output_entity_hints -> node_dependency_hints Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Update docstrings Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Auto-format Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix test_serialize_vscode Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Maybe fix the docs error Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix a newly added test from master Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> * Fix monodocs build Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> --------- Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com> Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com> Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/