in_windows_exporter_metrics: Plug bitwise glitches on 32bit oses#11940
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a per-context IWbemContext to the Windows exporter metrics input plugin, sets architecture VARIANTs in that context, passes it to ConnectServer/ExecQuery, fixes wide-string allocation, checks IWbemClassObject::Next HRESULTs, and releases the context on cleanup or failure. ChangesWMI Context Management
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbe50ecb98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
64b571c to
fb1194b
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
fb1194b to
eab065c
Compare
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
eab065c to
900c4cc
Compare
After long running investigations, we found that some of the bit width glitches on 32bit executable of Fluent Bit.
With this PR, we can retrieve prometheus compatible payloads from 32bit version of fluent-bit.exe.
Closes #10130.
I confirmed that it can retrieve from prometheus_exporter with curl(WebRequest-Invoke Cmdlet) on x86_64 Windows and 32bit/64bit exe pairs, and ARM64 Windows platforms.
32bit/64bit/arm64 executables of fluent-bit.exe are working as expected.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit