providesModule -> explicit requires for cross-package dependencies#9078
Merged
sebmarkbage merged 4 commits intofacebook:masterfrom Mar 1, 2017
Merged
providesModule -> explicit requires for cross-package dependencies#9078sebmarkbage merged 4 commits intofacebook:masterfrom
sebmarkbage merged 4 commits intofacebook:masterfrom
Conversation
sebmarkbage
requested review from
acdlite,
bvaughn,
gaearon,
sophiebits and
trueadm
Collaborator
|
Need to verify UMD builds still work correctly. |
Contributor
|
@gaearon maybe wait till you come into the office, I'd like you to step me through that process to see if there's anything I missed? Thanks man. |
Collaborator
|
Yea that was my plan! |
Contributor
|
@gaearon @sebmarkbage I've just tested the UMD bundles locally on your branch and they all look good to me! |
Files that require modules from a different package than their own now does so by the npm path name instead of the providesModule.
This is a bit lame but because of our module rewrite we need to white list all the paths that we don't *don't* want to rewrite.
sebmarkbage
force-pushed
the
forwardingmodules
branch
from
5c21cb5 to
a58e8cb
Compare
sophiebits
approved these changes
Mar 1, 2017
Collaborator
sophiebits
left a comment
sophiebits
left a comment
There was a problem hiding this comment.
It feels weird to require react/lib/* from files that get packaged into react, but I suppose this makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one step closer to a CommonJS/Lerna set up.
I added some forwarding modules for Flow and Jest's sake. They have the same purpose as the symlinks Lerna or Yarn Workspaces would provide.
I ran a codemod to use explicit package paths for cross-package dependencies and unit tests.
The rest of the requires are still providesModule.