Conversation
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
We also need a strategy for the "React with addons" build. I propose to delete it completely and move Perf to be an export on ReactDOM in (available only development). TestUtils doesn't need to be in a UMD build at all.
grunt/config/browserify.js
Outdated
| var dom = { | ||
| entries: [ | ||
| './build/node_modules/react-dom/lib/ReactDOMUMDEntry.js', | ||
| './build/node_modules/react-dom/lib/ReactDOMFiber.js', |
There was a problem hiding this comment.
I think we should keep this line as it is but change what ReactDOMUMDEntry exports.
There was a problem hiding this comment.
Sounds reasonable.
I'm a little confused by the module resolution system. Does require("ReactDOM") in UMDEntery points to the specific file or to the whole ReactDOM package (which is already exporting Fiber)?
The latter would mean that UMD build featured Fiber before this change. Which is false. Ok I got it.
Im open to implementing this, just not sure if it's directly related to/blocking this PR. Is it? |
|
Hmm, you're probably right that it doesn't block. |
|
If I look at |
|
Hey! I'm sorry for my mysterious disappearance. I'll try to solve this ASAP. One weird thing I see after rebasing to master is that UMD bundles fell back to exposing Stack. Guess it's due to #9078? I can confirm that bundle contains both implementations, but commenting out |
|
Let's hold off on this PR for now? Given the work that's currently going on with flat bundles and the build is likely to conflict with this PR. |
|
Yea, we’ll probably not go that road as we’re switching our build process. |
5 participants
Follow-up to #9015.
This PR switches UMD builds (
react-dom.jsandreact-dom.min.js) to useReactDOMFiberas an entry-point and removes-fiberbuilds altogether.The change breaks
examples/fiberand I intend to fix it with separate PR.