Remove 'unitless number' warning for 'content' style properties#6928
Closed
alexzherdev wants to merge 1 commit intofacebook:masterfrom
Closed
Remove 'unitless number' warning for 'content' style properties#6928alexzherdev wants to merge 1 commit intofacebook:masterfrom
alexzherdev wants to merge 1 commit intofacebook:masterfrom
Conversation
The 'content' style allows a multitude of value formats, some of which would classify as unitless numbers, so we should not issue a warning for this property.
ghost
added
Collaborator
|
We have the warning in all 15.x releases because it is a breaking change from 0.14. In 16+ we won't have the warning any more for any properties. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'content' style allows a multitude of value formats, some of which
would classify as unitless numbers, so we should not issue a
warning for this property.