Remove css px warning, stop appending px to strings#6899
Remove css px warning, stop appending px to strings#6899jimfb merged 1 commit intofacebook:masterfrom
Conversation
| it('should trim values', function() { | ||
| expect(CSSPropertyOperations.createMarkupForStyles({ | ||
| margin: '16 ', | ||
| left: '16 ', |
There was a problem hiding this comment.
Why change the property names?
There was a problem hiding this comment.
Eeh, setting margin to a unitless 16 felt weird. I can change them back I suppose.
There was a problem hiding this comment.
No weirder… you would probably never realistically set left to a unitless 16 either.
|
Did you fix up Facebook? |
|
I just landed #6677 (so I wouldn't have to do something in just the branch) so you'll have to rebase too. Sorry. |
jimfb
force-pushed
the
remove-unitless-warning
branch
from
73cca59 to
6a922c4
Compare
|
Ok, fixed+rebased. Also I have a diff up for FB internally. After that merges, we will want to do one last pass through the scuba logs immediately prior to doing the sync. |
jimfb
force-pushed
the
remove-unitless-warning
branch
from
6a922c4 to
a04cfdf
Compare
| opacity: 0.5, | ||
| padding: ' 4 ', | ||
| })).toBe('margin:16px;opacity:0.5;padding:4px;'); | ||
| })).toBe('left:16;opacity:0.5;right:4;'); |
There was a problem hiding this comment.
pretty sure this won't pass
jimfb
force-pushed
the
remove-unitless-warning
branch
4 times, most recently
from
840afe9 to
a1e5193
Compare
|
@jimfb updated the pull request. |
jimfb
force-pushed
the
remove-unitless-warning
branch
from
a1e5193 to
b205516
Compare
|
@jimfb updated the pull request. |
|
I was working on this little fix #6928 when I stumbled on this PR. It looks like this one is scheduled for the next major release, but I'm not sure how versions are handled. Is my PR not necessary at all then? |
jimfb
force-pushed
the
remove-unitless-warning
branch
from
b205516 to
b30ccff
Compare
|
@jimfb updated the pull request. |
5 participants
cc @spicyj @zpao can one of you stamp?