Add an ILLinkTrim.xml file for InteropServices.JavaScript.#37776
Add an ILLinkTrim.xml file for InteropServices.JavaScript.#37776eerhardt merged 3 commits intodotnet:masterfrom
Conversation
src/libraries/System.Runtime.InteropServices.JavaScript/src/ILLinkTrim.xml
Show resolved
Hide resolved
There was a problem hiding this comment.
I don't think descriptors are right approach here. Please use linker attributes instead, there is already linker attribute https://github.com/dotnet/runtime/blob/master/src/libraries/System.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs#L16 which should handle this if does not work we need to fix it
|
Discussed this offline with @marek-safar . It seems that This should work if there's something else in the managed code which will pull in the |
marek-safar
left a comment
There was a problem hiding this comment.
LGTM, we'll tweak our approach to use descriptors here (pushed one more here)
|
The only failures are ARM64 timeouts which, according to #37623 (comment), @safern is looking into. Merging now. |
|
Opened #37823 for arm64 timeouts. |
Fix #37775