Tfm clean up#37623
Merged
ericstj merged 3 commits intodotnet:masterfrom Jun 12, 2020
Anipik:tfmCleanUp
Merged
Conversation
|
Tagging subscribers to this area: @ViktorHofer |
jkotas
reviewed
Jun 9, 2020
ericstj
reviewed
Jun 10, 2020
Member
There was a problem hiding this comment.
Can this be changed to only reference public contracts?
Contributor
Author
There was a problem hiding this comment.
no, because some of the public types conflict with system.private.corelib
ericstj
approved these changes
Jun 12, 2020
Member
|
Only failures are ARM64 timeouts which @safern let me know he's looking into. Will see if I can file an issue on that. Merging now. |
Member
|
#37823 for arm64 timeouts |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34653