Skip to content

[wasm] Delete obsolete wasm console templates and related WASI build tests#129232

Open
Copilot wants to merge 6 commits into
mainfrom
copilot/delete-wasm-console-templates
Open

[wasm] Delete obsolete wasm console templates and related WASI build tests#129232
Copilot wants to merge 6 commits into
mainfrom
copilot/delete-wasm-console-templates

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This removes the obsolete wasmconsole and wasiconsole templates and deletes the WASI build-test coverage that existed only to exercise them. The remaining WASM/WASI wiring is updated to reflect the reduced template surface.

  • Template removal

    • Deletes src/mono/wasm/templates/templates/console
    • Deletes src/mono/wasm/templates/templates/wasi-console
  • Test and build cleanup

    • Deletes src/mono/wasi/Wasi.Build.Tests
    • Removes WASI build-test project references and solution entries
    • Clears the WASI build-app job list now that the template-driven test assembly is gone
  • Follow-up reference updates

    • Renames the default WASI runtimeconfig template file to remove the old wasiconsole naming
    • Updates docs and internal comments to describe the remaining browser template accurately
    • Removes stale WASI-template references from path evaluation and shared test helpers

Closes #127822
Closes #102743
Closes #95401

Co-authored-by: maraf <10020471+maraf@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 10, 2026 12:11
Copilot AI changed the title Delete obsolete wasm console templates and wasi build tests Delete obsolete wasm console templates and related WASI build tests Jun 10, 2026
Copilot finished work on behalf of maraf June 10, 2026 12:11
Copilot AI requested a review from maraf June 10, 2026 12:11
@maraf maraf changed the title Delete obsolete wasm console templates and related WASI build tests [wasm] Delete obsolete wasm console templates and related WASI build tests Jun 10, 2026
@maraf maraf added arch-wasm WebAssembly architecture os-wasi Related to WASI variant of arch-wasm os-browser Browser variant of arch-wasm labels Jun 10, 2026
@maraf maraf added this to the 11.0.0 milestone Jun 10, 2026
Update PackageFile to reference wasi.runtimeconfig.template.json after the rename from wasiconsole.runtimeconfig.template.json.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 16, 2026 09:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete wasmconsole and wasiconsole/WASI console template surface from the mono wasm template pack, and deletes the WASI build-test project that primarily existed to exercise those templates. Updates remaining WASM/WASI build wiring and documentation to reflect the reduced template/test surface.

Changes:

  • Delete the legacy wasm console templates (console, wasi-console) and their template metadata/files.
  • Remove src/mono/wasi/Wasi.Build.Tests and all associated solution/build references.
  • Update remaining WASM/WASI wiring (default runtimeconfig template name, path filters, docs, and small test infra cleanups).

Reviewed changes

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/mono/wasm/Wasm.Build.Tests/Wasm.Build.Tests.csproj Removes stale comment reference to now-deleted WASI build tests.
src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs Updates XML doc comment to reflect only the browser template remains.
src/mono/wasm/Wasm.Build.Tests/Common/Template.cs Removes Wasi template enum value to match reduced template surface.
src/mono/wasm/Wasm.Build.Tests/BrowserStructures/SharedBuildPerTestClassFixture.cs Updates TODO comment wording (now broader than WASI).
src/mono/wasm/templates/templates/wasi-console/wasi-console.0.csproj Removed obsolete WASI console template project file.
src/mono/wasm/templates/templates/wasi-console/README.md Removed obsolete WASI console template README.
src/mono/wasm/templates/templates/wasi-console/Properties/AssemblyInfo.cs Removed obsolete WASI console template assembly attribute file.
src/mono/wasm/templates/templates/wasi-console/Program.cs Removed obsolete WASI console template program stub.
src/mono/wasm/templates/templates/wasi-console/.template.config/template.json Removed obsolete WASI console template definition.
src/mono/wasm/templates/templates/console/runtimeconfig.template.json Removed obsolete wasm console runtimeconfig template.
src/mono/wasm/templates/templates/console/README.md Removed obsolete wasm console template README.
src/mono/wasm/templates/templates/console/Properties/AssemblyInfo.cs Removed obsolete wasm console template assembly attribute file.
src/mono/wasm/templates/templates/console/Program.cs Removed obsolete wasm console template program stub.
src/mono/wasm/templates/templates/console/main.mjs Removed obsolete wasm console template JS host file.
src/mono/wasm/templates/templates/console/console.0.csproj Removed obsolete wasm console template project file.
src/mono/wasm/templates/templates/console/.template.config/template.json Removed obsolete wasm console template definition.
src/mono/wasm/sln/WasmBuild.slnx Drops the removed Wasi.Build.Tests project from the wasm solution.
src/mono/wasi/Wasi.Build.Tests/WasiTemplateTests.cs Removed WASI template-driven build/run tests.
src/mono/wasi/Wasi.Build.Tests/WasiLibraryModeTests.cs Removed WASI library-mode build tests.
src/mono/wasi/Wasi.Build.Tests/Wasi.Build.Tests.csproj Removed WASI build test project file and related test infra wiring.
src/mono/wasi/Wasi.Build.Tests/SharedBuildPerTestClassFixture.cs Removed duplicated fixture from deleted WASI test project.
src/mono/wasi/Wasi.Build.Tests/SdkMissingTests.cs Removed WASI “SDK missing” scenario tests tied to template-driven builds.
src/mono/wasi/Wasi.Build.Tests/RuntimeConfigTests.cs Removed WASI runtimeconfig template test tied to template project layout.
src/mono/wasi/Wasi.Build.Tests/README.md Removed WASI build tests documentation.
src/mono/wasi/Wasi.Build.Tests/PInvokeTableGeneratorTests.cs Removed WASI P/Invoke table generator test tied to template project.
src/mono/wasi/Wasi.Build.Tests/InvariantTests.cs Removed WASI invariant globalization/timezone tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/ILStripTests.cs Removed WASI IL strip tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/HttpTests.cs Removed WASI HTTP sample build/run tests tied to template project.
src/mono/wasi/Wasi.Build.Tests/Directory.Build.targets Removed WASI build-tests-specific targets file.
src/mono/wasi/Wasi.Build.Tests/Directory.Build.props Removed WASI build-tests-specific props file.
src/mono/wasi/Wasi.Build.Tests/data/Workloads.Directory.Build.targets Removed workload-mode build-test targets file.
src/mono/wasi/Wasi.Build.Tests/data/Workloads.Directory.Build.props Removed workload-mode build-test props file.
src/mono/wasi/Wasi.Build.Tests/data/Local.Directory.Build.targets Removed local-mode build-test targets file.
src/mono/wasi/Wasi.Build.Tests/data/Local.Directory.Build.props Removed local-mode build-test props file.
src/mono/wasi/Wasi.Build.Tests/BuildTestBase.cs Removed WASI build-test base implementation (template-driven).
src/mono/wasi/Wasi.Build.Tests/BuildPublishTests.cs Removed WASI build/publish coverage that was template-driven.
src/mono/wasi/README.md Updates WASI docs to remove template usage guidance and point to samples/manual authoring.
src/mono/wasi/build/WasiApp.targets Renames default runtimeconfig template reference to the new file name.
src/mono/wasi/build/wasi.runtimeconfig.template.json Adds the renamed default WASI runtimeconfig template file.
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk.pkgproj Updates package content to include the renamed runtimeconfig template.
src/mono/browser/README.md Updates template docs to describe only wasmbrowser remaining.
src/libraries/tests.proj Removes WASI build test project reference from libraries test orchestration.
eng/testing/scenarios/BuildWasiAppsJobsList.txt Clears the WASI build-app job list now that the template-driven test assembly is removed.
eng/pipelines/common/evaluate-default-paths.yml Removes Wasi.Build.Tests from WASM path evaluation subsets and updates comment text accordingly.
docs/workflow/wasm-documentation.md Updates guidance to use Wasm.Build.Tests for browser and samples for WASI validation.

@maraf maraf marked this pull request as ready for review June 16, 2026 10:02
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 16, 2026 10:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Comment thread eng/pipelines/common/evaluate-default-paths.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 16, 2026 10:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 44 out of 45 changed files in this pull request and generated 1 comment.

Comment thread src/mono/wasi/README.md
Remove run-build-tests and submit-wbt-helix targets that reference the deleted Wasi.Build.Tests project.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm os-wasi Related to WASI variant of arch-wasm

Projects

None yet

3 participants