Skip to content

Add support for Apple Development certificates to Xamarin.Mac MSBuild #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mandel-macaque merged 3 commits into from
Aug 28, 2019
Merged

Add support for Apple Development certificates to Xamarin.Mac MSBuild #6797

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbad1db
Add Apple Development certificates to Mac DetectSigningIdentity task
wjk Aug 19, 2019
2876065
Update PlatformName value
wjk Aug 19, 2019
9e3b976
Merge branch 'master' into apple-development
mandel-macaque Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions msbuild/Xamarin.Mac.Tasks/Tasks/DetectSigningIdentity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ namespace Xamarin.Mac.Tasks
{
public class DetectSigningIdentity : DetectSigningIdentityTaskBase
{
static readonly string[] appStoreDistributionPrefixes = { "3rd Party Mac Developer Application" };
static readonly string[] appStoreDistributionPrefixes = { "3rd Party Mac Developer Application", "Apple Distribution" };
static readonly string[] directDistributionPrefixes = { "Developer ID Application" };
static readonly string[] developmentPrefixes = { "Mac Developer" };
static readonly string[] developmentPrefixes = { "Mac Developer", "Apple Development" };

protected override string[] DevelopmentPrefixes { get { return developmentPrefixes; } }
protected override string[] DirectDistributionPrefixes { get { return directDistributionPrefixes; } }
protected override string[] AppStoreDistributionPrefixes { get { return appStoreDistributionPrefixes; } }
protected override string DeveloperRoot { get { return MacOSXSdks.Native.DeveloperRoot; } }
protected override PlatformFramework Framework { get { return PlatformFramework.MacOS; } }
protected override string PlatformName { get { return "OS X"; } }
protected override string PlatformName { get { return "macOS"; } }

@dalexsoto dalexsoto Aug 27, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite sure about this one but as long as our tests are happy 👍

protected override string ApplicationIdentifierKey { get { return "com.apple.application-identifier"; } }
}
}