Add support for Apple Development certificates to Xamarin.Mac MSBuild#6797
Merged
Conversation
Contributor
|
build |
Contributor
|
Build success |
Member
The way to do this is to create a fork of the Xamarin.MacDev, create a pull request with your changes, and once that pull request has been merged, update this pull request with the submodule bump. |
mandel-macaque
approved these changes
Aug 26, 2019
Merged
dalexsoto
approved these changes
Aug 27, 2019
| protected override string DeveloperRoot { get { return MacOSXSdks.Native.DeveloperRoot; } } | ||
| protected override PlatformFramework Framework { get { return PlatformFramework.MacOS; } } | ||
| protected override string PlatformName { get { return "OS X"; } } | ||
| protected override string PlatformName { get { return "macOS"; } } |
Member
There was a problem hiding this comment.
Not quite sure about this one but as long as our tests are happy 👍
emaf
approved these changes
Aug 27, 2019
chamons
approved these changes
Aug 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does mostly what the title says. I also took the opportunity to update an occurrence of "OS X" to the current branding.
Please note that I was not able to change the corresponding value for the iOS platform because those constants are in the Xamarin.MacDev submodule, and if I was make the changes in a fork, I would then have problems properly reintegrating the submodule change into this repository. I have included the required changes as a diff below; if someone could apply them for me (or tell me how I should best apply them myself), I would appreciate it. Thanks!