docs: Update obsolete default exports in package.json#899
docs: Update obsolete default exports in package.json#899donysukardi wants to merge 1 commit intodevelopit:masterfrom
default exports in package.json#899Conversation
|
|
That's absolutely a valid key, just not one we check (at the moment) while generating output. Nothing obsolete there. In the past, when that was written, we never checked the children of This could change at some point though, see #853 (comment) |
|
I see. I suppose it’s a regression then based on the linked issue. I copied the example in the readme and was surprised that it didn’t work |
|
There's no regression, that was never supported. |
|
Then the example is incorrect given the current state |
|
It's correct, just not fulfilling the behavior you wish. You need to ensure yourself that the name matches up. Again, hopefully this will be better in the future, but for now, that might mean a post-build renaming/copying of files. |
|
I don't really understand the confusion here, clearly the example in the |
|
The confusion is that they believed export keys were no longer valid based on us not checking for them. We don't check for every key of exports to generate output for, and never have. It'd certainly be nice to be able to, but that's not the point we're at. The example is valid and correctly formed, no issues with it. I believe there's a PR open for adding Edit: Actually, that PR has been merged in and the patch released, everything should be working. @sirianni, do you have a specific problem with it? |

Current example uses
default, which is no longer valid based the following codemicrobundle/src/index.js
Lines 262 to 265 in b1a6374