Fix exports walk (#852)

[developit]

Fixes #852

[changeset-bot]

🦋 Changeset detected

Latest commit: 9a9b45c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
microbundle	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[rschristian]

This does start to make me worry that #784 was a bad idea, due to the amount of possible combinations that we can't reasonably cover, requiring users to fix filenames on their end.

[jeffryang24]

Hmm... I found a regression when declaring modern exports using default conditional export, such as:

"exports": {
    ".": {
      "import": "dist/index.js",
      "require": "dist/index.cjs",
      "default": "dist/index.modern.js"
    }
  }

The modern module is not being generated in version >= 0.13.2 while it is being generated in v0.13.1. Probably, we can also add exports.default inside the walk recursion method. wdyt @developit ? 🙇

Suggested change

	return walk(exports['.'] || exports.import || exports.module);
	return walk(exports['.'] || exports.import || exports.module || exports.default);

[jeffryang24]

any update regarding this fix? 🙇

[developit]

Hi @jeffryang24 - no update, just haven't gotten around to it yet.

[developit]

I think we could add .default as you suggest, but really this needs to also be checking the extension based on pkg.type, otherwise it will potentially return a CommonJS entry filename for the modern filename.

I have a fairly large overhaul of this logic that uses a complete Package Exports implementation to determine names, but I haven't had a chance to get tests passing for it yet.

[jeffryang24]

I see... got it... Currently, I've reverted back to 0.13.1 to fix this regression issue. Thanks for your explanation... 🙇

[ChristophP]

@jeffryang24 thanks, I also reverted to 0.13.1 and that makes it work for me for the moment.