Also skip server-side test subtrees on macOS (follow-up to #5072)#5073
Closed
pietern wants to merge 1 commit intotest-time-windows-skipfrom
Closed
Also skip server-side test subtrees on macOS (follow-up to #5072)#5073pietern wants to merge 1 commit intotest-time-windows-skipfrom
pietern wants to merge 1 commit intotest-time-windows-skipfrom
Conversation
Extends the windows skip from the parent PR to macOS. Same argument: the subtrees that were skipped on windows exercise server-side logic through bundle deploy/update cycles and don't exercise OS-specific CLI behavior. Linux runs cover them fully. Also hoists the permissions skip to the parent `resources/` test.toml (so every `resources/*` directory inherits it) and adds four more subtrees that match the same pattern: - `bundle/resources/` (parent -- was just `permissions/` before): covers jobs, pipelines, clusters, dashboards, grants, model_serving_endpoints, postgres_*, quality_monitors, secret_scopes, volumes, etc. - `bundle/deployment/bind/` and `bundle/deployment/unbind/`: server-side state binding - `bundle/run_as/`: server-side identity impersonation - `bundle/resource_deps/`: server-side dependency resolution `out.test.toml` files regenerated via `make generate-out-test-toml`. Expected incremental impact on top of the parent PR: - windows/terraform: should drop from ~23m toward ~12-15m - macos/terraform: should drop from ~13m toward ~7-9m - linux/terraform unchanged (full coverage preserved) Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacks on #5072. Two changes:
1. Also skip on macOS
The subtrees skipped on Windows in #5072 exercise server-side logic via bundle deploy/update cycles; none of them exercise OS-specific CLI behavior. Linux gives full coverage. Extending the skip to macOS removes redundant CI minutes and trims macOS/terraform wall-clock.
2. More subtrees that match the same pattern
Gotestsum profiling (PR #5068) shows Windows runs at ~2.1-2.4x Linux per test uniformly. After the #5072 cuts the remaining big contributors to windows/terraform are still all server-side:
bundle/resources/jobsbundle/deployment/bindbundle/resources/model_serving_endpointsbundle/resources/dashboardsbundle/resources/clustersbundle/resources/pipelinesbundle/resources/grantsbundle/run_as/pipelinesbundle/resources/postgres_*bundle/resource_deps/*None of these exercise Windows/macOS-specific CLI behavior — they're all server-side resource management through bundle deploy. Linux coverage is sufficient.
Changes
GOOS.windows = false; GOOS.darwin = falsehoisted tobundle/resources/test.toml(covers all resources/, subsumes the permissions-specific entry from Skip server-side acceptance tests on Windows and macOS #5072).test.tomlfiles fortemplates/default-python/{combinations,integration_classic,serverless}(replaces the Windows-only skip from Skip server-side acceptance tests on Windows and macOS #5072).test.tomlfiles forbundle/deployment/bind/,bundle/deployment/unbind/,bundle/run_as/.bundle/resource_deps/test.toml.out.test.tomlfiles regenerated viamake generate-out-test-toml.Expected impact (stacked on #5072)
Test plan
This pull request and its description were written by Isaac.