Skip server-side acceptance tests on Windows and macOS#5072
Open
Skip server-side acceptance tests on Windows and macOS#5072
Conversation
3 tasks
Profiling via gotestsum JSON (PR #5068) shows Windows acceptance tests run at 2.1-2.4x the Linux duration uniformly across every directory, and a large subset of those tests exercise server-side logic through bundle deploy/update cycles without touching OS-specific CLI behavior. Linux coverage alone is sufficient for those subtrees. Skipping on both Windows and macOS (via GOOS.windows/GOOS.darwin = false) in: - `bundle/resources/` — jobs, pipelines, clusters, dashboards, grants, permissions, model_serving_endpoints, postgres_*, quality_monitors, secret_scopes, volumes, models, registered_models, schemas, etc. - `bundle/deployment/bind/` and `bundle/deployment/unbind/` -- server-side state binding - `bundle/run_as/` -- server-side identity impersonation - `bundle/resource_deps/` -- server-side dependency resolution - `bundle/templates/default-python/{combinations,integration_classic, serverless}` -- server-side template rendering; Windows/macOS still smoke-tests the template machinery via `templates/default-python/ classic/`. All `out.test.toml` files regenerated via `make generate-out-test-toml` so the materialized config snapshot reflects the new GOOS filters. Expected impact: - windows/terraform: ~32m -> ~12-15m - macos/terraform: ~13m -> ~7-9m - linux/terraform: unchanged (full coverage preserved) Co-authored-by: Isaac
pietern
force-pushed
the
test-time-windows-skip
branch
from
8a992ba to
0d23102
Compare
pietern
changed the title
pietern
requested review from
andrewnester,
denik,
janniklasrose and
simonfaltum
janniklasrose
approved these changes
Apr 23, 2026
Contributor
janniklasrose
left a comment
janniklasrose
left a comment
There was a problem hiding this comment.
Is there a flag we can set to run them in local (on macOS)? Presumably not all will be run after this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows acceptance tests run at 2.1–2.4× the Linux duration uniformly across every directory. A large subset of those tests exercise server-side logic via bundle deploy/update cycles and don't touch OS-specific CLI behavior. Linux coverage alone is sufficient for those subtrees.
Subtrees skipped on Windows + macOS
bundle/resources/(all resources: jobs, pipelines, clusters, dashboards, grants, permissions, model_serving_endpoints, postgres_*, quality_monitors, secret_scopes, volumes, etc.)bundle/templates/default-python/combinationsbundle/templates/default-python/integration_classicbundle/templates/default-python/serverlessbundle/deployment/bind/bundle/deployment/unbind/bundle/run_as/bundle/resource_deps/bundle/templates/default-python/classic/still runs on Windows and macOS as the template-machinery smoke test.Changes
GOOS.windows = false+GOOS.darwin = falseset on:bundle/resources/test.toml(parent)bundle/templates/default-python/{combinations,integration_classic,serverless}/test.tomlbundle/deployment/bind/test.toml(new)bundle/deployment/unbind/test.toml(new)bundle/run_as/test.toml(new)bundle/resource_deps/test.tomlAll
out.test.tomlfiles regenerated viamake generate-out-test-toml; verified locally withmake test-update.Measured impact
Linux timings unchanged — full coverage preserved. No test regressions.
This pull request and its description were written by Isaac.