DIP4 implementation#2251
Merged
Merged
Conversation
UdjinM6
requested changes
Aug 31, 2018
There was a problem hiding this comment.
Should probably add smth like
else if (strCommand == NetMsgType::MNLISTDIFF) {
// we have never requested this
LOCK(cs_main);
Misbehaving(pfrom->id, 100);
}
Also add "coinbase_payload" field to block templates
Also add "protx diff" RPC
These are only meant to be sent to SPV clients
Author
|
Pushed review fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements DIP4 and is extracted from #2083. It is activated at the same time as DIP2 and DIP3.
The PR currently also includes the commits from #2250, which I'll remove after it is merged.