Implementation of remaining DIP3 special transactions#2250
Merged
Conversation
Merged
UdjinM6
reviewed
Aug 31, 2018
UdjinM6
left a comment
UdjinM6
left a comment
There was a problem hiding this comment.
Just a few small things, otherwise looks good imo 👍
codablock
force-pushed
the
pr_dip3_othertxs
branch
from
ed42d4e to
58aa813
Compare
Author
|
Pushed review fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining DIP3 special transactions: ProUpServTx, ProUpRegTX and ProUpRevTX
It still has no influence on the system, even if the BIP9 deployment gets activated. It only allows to mine these.
Next PR will include DIP4 special transactions. After that, I'll start with the PRs for the real MN logic, including compatibility code.