Conversation
Merged
sebastian-nagel
requested changes
Feb 11, 2026
sebastian-nagel
left a comment
sebastian-nagel
left a comment
There was a problem hiding this comment.
Hi @lfoppiano, thanks!
To run it with local files some changes are required. At least, as far I could test it. See the inline comments.
# Conflicts: # Makefile # README.md
sebastian-nagel
approved these changes
Feb 12, 2026
sebastian-nagel
left a comment
sebastian-nagel
left a comment
There was a problem hiding this comment.
Thanks, @lfoppiano. Looks good! Testing DuckDb with local files works seamlessly.
Collaborator
Author
|
Thank you for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we adds:
local_parquetthat allow the user to specify a local directory to query the index using DuckDb:make local_parquet LOCAL_DIR=/my/local/parquetThis was suggested by Sebastian here