Merged
Conversation
lfoppiano
requested review from
sebastian-nagel
and removed request for
sebastian-nagel
sebastian-nagel
requested changes
Jan 15, 2026
sebastian-nagel
left a comment
sebastian-nagel
left a comment
There was a problem hiding this comment.
See inline comments.
Same as for other PRs: TEST-000000.* and whirlwind.parquet are written into the repository home folder. Could keep them elsewhere.
| public static List<String> getFiles(Algorithm algo, String crawl) throws IOException { | ||
| switch (algo) { | ||
| case CCF_LOCAL_FILES: { | ||
| Path indexPath = Path.of("/home/cc-pds/commoncrawl/cc-index/table/cc-main/warc", "crawl=" + crawl, |
There was a problem hiding this comment.
Why not use data/downloads/cc-index/table/... and add a target to download the Parquet files showing a warning about the amount of data going to be downloaded?
Collaborator
Author
There was a problem hiding this comment.
@sebastian-nagel I've moved your suggestion to #14 for validation since it might require to sync also the python whirlwind tour.
# Conflicts: # Makefile # README.md
Collaborator
Author
|
👍🙏 thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add Task 8 and the Bonus. I wrote a corresponding Java class Duck.java which mimick 1:1 the Python
duck.py. I did not include the non-supported algorithms / tasks.There are some part of the Task 8 that are working only in the development server, we might want to add additional information about it. What's your opinion?