[Workers] Clarify observability pricing#31428
Conversation
|
This PR requires additional review attention because it affects the following areas: PartialsThis PR updates partial files, which are pieces of content used across multiple files in our Render component.
|
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
89f5350 to
55f4a5c
Compare
|
Here is my review of PR #31428. Labels
SummaryThis PR improves the clarity of Workers observability pricing by distinguishing between Workers Logs (persisted/queryable log events) and Workers Trace Events Logpush (exported events). It:
Validation results
Note: I was able to run these checks successfully in this environment (Node v24.16.0 / pnpm 11.6.0). Review: Approved with minor nitsThe changes are accurate, consistent with repo conventions, and materially improve clarity. I have two minor wording suggestions for maintainers to consider: 1. Redundant / ambiguous clause in additive-pricing sentencesBoth paragraphs repeat the phrase "where both overage rates apply", which is slightly redundant because the preceding clause already establishes the condition (events are both persisted and exported).
- If an event is both persisted by Workers Logs and exported by Workers Trace Events Logpush, the combined overage rate is $0.65 per million events where both overage rates apply.
+ If an event is both persisted by Workers Logs and exported by Workers Trace Events Logpush, the combined overage rate is $0.65 per million such events.
- If you both export events with Workers Trace Events Logpush and persist logs with Workers Logs, the combined overage rate is $0.65 per million events where both overage rates apply.
+ If you both export events with Workers Trace Events Logpush and persist logs with Workers Logs, the combined overage rate is $0.65 per million events that are both persisted and exported.2. Optional: Deduplicate the additive-pricing paragraphThe same additive-pricing explanation appears after both the Workers Logs section and the Workers Trace Events Logpush section. This is helpful for readers who land on only one section, but if the docs team prefers a single source of truth, it could be reduced to one note/callout and a cross-reference. Not a blocker. Other observations
Overall, this is a clean, focused docs improvement. LGTM once the author/maintainer decides on the wording nits above. |
55f4a5c to
85d7cbb
Compare
|
Preview URL: https://85d7cbb5.preview.developers.cloudflare.com Files with changes (up to 15)
|
|
/bonk update this PR to make @nevikashah codeowner of the workers observability partial that changed |
Co-authored-by: irvinebroque <irvinebroque@users.noreply.github.com>
|
Done. I added + /src/content/partials/workers/workers_logs_pricing.mdx @irvinebroque @mikenomitch @nevikashah @cloudflare/product-owners @vy-tonThe new entry shares the same owner list as the existing |
Summary
Validation
git diff --check origin/production...HEADFull docs validation was not run in this sandbox because it has Node 22 and no pnpm/corepack, while this repo requires Node 24.