Merge bbc/react-transcript-editor@master in#2
Merged
chrishutchinson merged 43 commits intochrishutchinson:masterfrom Mar 18, 2019
Merged
Merge bbc/react-transcript-editor@master in#2chrishutchinson merged 43 commits intochrishutchinson:masterfrom
bbc/react-transcript-editor@master in#2chrishutchinson merged 43 commits intochrishutchinson:masterfrom
Conversation
to accomodate for two new fields
leaving rest for another branch/PR tbc
…or into layout-change
…r into layout-change
This reverts commit 2c6a9dd.
removed volume component and added titles tags to player controls btns
mobile break point
eg linting, css etc.. from James' PR feedback
+ Range bar re-styled
+ Added Toggle sound
Layout changes accessibility review
* added aws transcribe sample without channel enabled * latest * fixed up offset * fixed up punctuation errors * removed debugger statement * fixing few things * finalized 1st draft * removed my redundant generateEntitiesRanges method * added .test.js file * reintroduced linting, added example usage * tried to fix the test * added timecodes to full stop and commas * merged punctuation with previous word * removed unnecessary debugger * cleaned up spacing in test.js * fixed autoEdit adapter issue * refactor test example for AWS -> got tests to pass * updated docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.