Merged
Conversation
…/react-transcript-editor into Gribbs-stt-adapter-awstranscribe
Create React App, react scripts already have eslit, but not explicitly in the package.json
|
Thanks for this! My use case isn’t fully formed yet really. I was just searching for an easy way to cleanup an AWS Transcribe job after realising the transcript file can’t be used as-is in a fully automated flow. I’m thinking I’ll setup a flow that creates a transcribe job when a video/audio file is added to S3 using AWS Lambda. This transcript file can then be cleaned up by an admin user with this component and then the clean file will be sent to another bucket on save for viewing by end users alongside the original video. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Issue #108 and PRs #119 #118 #116 #110 by @Gribbs
Describe what the PR does
Adds support for AWS Adapter for @bbc/react-transcript-editor
State whether the PR is ready for review or whether it needs extra work
Additional context
Thanks @Gribbs, looks all good to go, happy to merge to master, and future tweaks and improvements can be done as separate PRs.
Out of curiosity was wondering what's your use case for this component?