[Torch] Fix converting torch slice op with dynamic slice length#7549
Merged
comaniac merged 2 commits intoapache:mainfrom Mar 2, 2021
Merged
[Torch] Fix converting torch slice op with dynamic slice length#7549comaniac merged 2 commits intoapache:mainfrom
comaniac merged 2 commits intoapache:mainfrom
Conversation
masahi
force-pushed
the
torch-slice-dyn-len
branch
from
53c1069 to
5efd741
Compare
masahi
force-pushed
the
torch-slice-dyn-len
branch
from
5efd741 to
1f3f00d
Compare
apivovarov
approved these changes
Mar 2, 2021
Member
Author
|
ping @kevinthesun @comaniac @siju-samuel this is ready to go, @apivovarov needs this fix |
Contributor
|
Thanks @masahi @apivovarov |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
…he#7549) * Fix converting torch slice op with dynamic slice length * use isinstance Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
…he#7549) * Fix converting torch slice op with dynamic slice length * use isinstance Co-authored-by: masa <masa@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7546
This is an easy PR to fix the bug introduced in #7479. Thanks @apivovarov for reporting.
Please review @kevinthesun @comaniac @siju-samuel @apivovarov