[Torch] Avoid adding unnecessary slicing#7479
Merged
masahi merged 3 commits intoapache:mainfrom Feb 26, 2021
Merged
Conversation
Member
Author
|
ping @kevinthesun @anijain2305 @siju-samuel this should be easy and no brainer |
Contributor
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* simplyfing * improved fast path for slice * update rewrite pattern for maskrcnn
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* simplyfing * improved fast path for slice * update rewrite pattern for maskrcnn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch object detection models have many uses of slicing like
arr[:, None]which is essentially nop, see for example https://github.com/pytorch/vision/blob/f7fae490980885e426fef01bb214025b9eddb832/torchvision/models/detection/roi_heads.py#L80The current
aten::sliceconverter does not detect such nop slicing and inserts unnecessarystrided_slice. The worst of all, many ofarr[:, None]converts to dynamic strided slice, which results in too muchany_dim.I simplified
aten::sliceconversion and fixed the fast path detection. I've updated MaskRCNN rewrite pattern to remove one ofdyn.strided_slice, which serves as a test case.please review @kevinthesun @anijain2305 @siju-samuel