[Relay][TOPI] Gluncv SSD support on the GPU by Laurawly · Pull Request #2784 · apache/tvm

Laurawly · 2019-03-12T01:11:45Z

Following PR #2353, applying apis accordingly, support glunocv ssd models on the GPU.
Also exposed coord_start, score_index variables to frontend for supporting more object detection networks. Added argsort as an operator, support both CPU and GPU. Adaptive pooling op exposed.

kevinthesun · 2019-03-13T00:20:26Z

Overall lgtm. One more thing is what is the situation of gpu related grammar sugars supporting in hybrid script? @were If possible we can migrate vision op to hybrid script implementation as well.

Laurawly · 2019-03-13T17:09:45Z

Overall lgtm. One more thing is what is the situation of gpu related grammar sugars supporting in hybrid script? @were If possible we can migrate vision op to hybrid script implementation as well.

Currently, I'm still experimenting with the hybrid script. There could still be some problems. But I'll communicate with @were during the process.

kevinthesun · 2019-04-24T18:39:49Z

LGTM. @Laurawly Can you open an issue to track the progress to migrate from ir_builder to hybrid script?

icemelon

Some high level comment:

argsort doesn't consider output dtype as int
we shouldn't place sort-related op under vision category

icemelon

Could you also update the doc?

icemelon · 2019-04-26T23:24:44Z

    return _default_schedule(outs, False)
+
+@tvm.target.generic_func
+def schedule_argsort(outs):


move this function to topi/generic/sort.py

icemelon · 2019-04-27T06:07:18Z



+**Level 6: Algorithm Operators**
+-------------------


Remove this line

tqchen · 2019-04-27T16:37:27Z

@Laurawly please act on @icemelon9 's remaining comment

Laurawly · 2019-04-28T21:56:39Z

@Laurawly please act on @icemelon9 's remaining comment

Comments addressed.

icemelon · 2019-04-29T03:47:25Z

Thanks everyone. This is now merged.

* ssd gluoncv gpu op updated * ssd gluoncv gpu op updated * tutorials and testes modified * tutorials and testes modified * fix lint * fix lint * address comment * multibox bug fixed * space line added * use less threads per block * use less threads per block * less threads per block for get valid count * less threads per block for get valid count * merge with master * Revert "less threads per block for get valid count" This reverts commit 08896cf. * Revert "less threads per block for get valid count" This reverts commit 08896cf. * typo fixed * elem length made to a variable * fix lint error * fix lint error * lint fixed * bug fixed * bug fixed * lint fixed * error fixed * error fixed * test ci * test ci * seperate argsort to be an independent op * seperate argsort to be an independent op * fix lint * fix lint * remove unsupported models * typo fixed * argsort added to realy * solve conflicts with master * fix lint * fix lint * test push * Revert "test push" This reverts commit 6db0088. * fix lint error * fix more lint * cpu test_sort udpated * debug ci * nms fixed * expose argsort to relay frontend * test ci * fix lint * sort register error fixed * fix nnvm * nms type fixed * adaptive pooling added to relay * Revert "adaptive pooling added to relay" This reverts commit 1119f1f. * fix lint * expose argsort op * fix lint * fix lint * fix lint * sort test updated * sort bug fixed * nnvm error fixed * fix argsort default data type returned to be float insteaf of int * fix lint * fix lint * test fixed * fix valid count * fix titanx bug * tutorial add both targets * titanx error fixed * try to fix CI old gpu error * try to solve CI GPU error * get_valid_count added * reverse get_valid_count * get valid count optimized * address comments * fix ci error * remove unessesary block sync * add back one sync * address comments * address more comments * more comments * move sort to be indepent algorithm * typo fixed * more typos * comments addressed * doc updated * fix pylint * address final comments * apache license added

Laurawly requested review from kevinthesun and tqchen March 12, 2019 01:11

apivovarov reviewed Mar 12, 2019

View reviewed changes

Comment thread tutorials/frontend/deploy_ssd_gluoncv.py Outdated

Laurawly requested a review from masahi March 12, 2019 03:25

Laurawly force-pushed the dev branch from cb32578 to 2b63f24 Compare March 12, 2019 04:17

tqchen added the status: need review label Mar 12, 2019

kevinthesun requested changes Mar 12, 2019

View reviewed changes

Comment thread topi/python/topi/cuda/nms.py

Comment thread topi/python/topi/cuda/nms.py

Comment thread topi/python/topi/cuda/nms.py

Laurawly force-pushed the dev branch from e685004 to a81aed6 Compare March 12, 2019 19:59

Laurawly force-pushed the dev branch 6 times, most recently from 83d1ab2 to b66ff61 Compare March 15, 2019 21:52

Laurawly requested a review from kevinthesun March 15, 2019 21:54

Laurawly force-pushed the dev branch 4 times, most recently from d6830a2 to 02855fa Compare March 18, 2019 05:43

liangfu reviewed Mar 18, 2019

View reviewed changes

Comment thread tutorials/frontend/deploy_ssd_gluoncv.py Outdated

Laurawly requested a review from Huyuwei as a code owner March 19, 2019 20:42

Laurawly force-pushed the dev branch 4 times, most recently from a4789e8 to a7b5d9e Compare March 22, 2019 20:25

Laurawly closed this Mar 22, 2019

Laurawly deleted the dev branch March 22, 2019 20:28

Laurawly restored the dev branch March 22, 2019 20:31

address comments

37630b8

kevinthesun approved these changes Apr 24, 2019

View reviewed changes

icemelon requested changes Apr 25, 2019

View reviewed changes

Laurawly added 5 commits April 25, 2019 18:24

address more comments

d1aec1a

more comments

10e466e

move sort to be indepent algorithm

8b5708f

typo fixed

ee4a8fd

more typos

7c8317d

icemelon requested changes Apr 26, 2019

View reviewed changes

Laurawly added 3 commits April 26, 2019 23:39

comments addressed

bbb83cc

doc updated

97051e7

fix pylint

f335399

Laurawly requested a review from icemelon April 27, 2019 05:28

icemelon approved these changes Apr 27, 2019

View reviewed changes

kevinthesun mentioned this pull request Apr 27, 2019

[TUTORIAL] Deploy GluonCV some ssd tutorial models fail #3103

Closed

tqchen added status: need update need update based on feedbacks and removed status: need review labels Apr 27, 2019

Laurawly added 2 commits April 28, 2019 21:47

address final comments

5c52634

apache license added

143a515

icemelon added status: accepted and removed status: need update need update based on feedbacks labels Apr 29, 2019

icemelon merged commit a706ad1 into apache:master Apr 29, 2019

Laurawly deleted the dev branch April 30, 2019 17:12

tqchen mentioned this pull request Nov 8, 2019

[RELEASE][DRAFT] TVM v0.6 Release candidate #4259

Closed



		Level 6: Algorithm Operators
		-------------------

Conversation

Laurawly commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevinthesun commented Mar 13, 2019

Uh oh!

Laurawly commented Mar 13, 2019

Uh oh!

Uh oh!

kevinthesun commented Apr 24, 2019

Uh oh!

icemelon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icemelon left a comment

Choose a reason for hiding this comment

Uh oh!

icemelon Apr 26, 2019

Choose a reason for hiding this comment

Uh oh!

icemelon Apr 27, 2019

Choose a reason for hiding this comment

Uh oh!

tqchen commented Apr 27, 2019

Uh oh!

Laurawly commented Apr 28, 2019

Uh oh!

icemelon commented Apr 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Laurawly commented Mar 12, 2019 •

edited

Loading