[Object Detection] Gluoncv SSD support on CPU by kevinthesun · Pull Request #2353 · apache/tvm

kevinthesun · 2018-12-29T04:39:43Z

This PR refactors vision operators with hybrid script(thanks to @were). Now gluoncv SSD with resnet and mobilenet are supported in nnvm. SSD with vgg are not supported since x86 conv2d_NCHWc doesn't support dilation yet. Two tasks need to be done:

Multibox related ops are not supported by hybrid script yet since array container is not supported as argument. @were is working on this. Although gluoncv SSD models don't need these operators, legacy mxnet ssd models use them.
Support for relay ir.

kevinthesun · 2019-01-14T22:30:30Z

Now full support for nnvm is ready. For relay, the only issue is flaky compilation probably caused by relay compiler engine: https://discuss.tvm.ai/t/relay-flaky-compilation-behavior/1478
ssd vgg is not supported yet, since dilation conv2d optimization is not supported in cpu.

The code is ready to be reviewed now. @tqchen @zhreshold @Laurawly @vinx13 @were

Thanks for @were 's support of hybrid script!

vinx13 · 2019-01-15T13:09:35Z

 **Author**: `Yao Wang <https://github.com/kevinthesun>`_

 This article is an introductory tutorial to deploy SSD models with TVM.
+<<<<<<< HEAD


unresolved conflict

kevinthesun · 2019-01-15T18:11:00Z

The relay issue has been resolved.
@tqchen We might need gluoncv in ci.

Laurawly · 2019-01-15T22:54:04Z

+                    np_out2[i, j, k] = -1
+
+    target = "llvm"
+    ctx = tvm.cpu()


Expanding target and ctx to for target, ctx in ctx_list(): can make this function look more generalized.

Will it fail in CI if gpu targets haven't been supported yet?

If so, adding if target == 'cuda' : continue will work.

Laurawly · 2019-01-15T23:07:17Z

        f(tvm_data, tvm_valid_count, tvm_out)
        tvm.testing.assert_allclose(tvm_out.asnumpy(), np_result, rtol=1e-4)

-    for device in ['llvm', 'opencl', 'cuda']:


Does this one fail with 'opencl' and 'cuda'?

get_valid_counts need to be implemented for gpu targets.

Laurawly · 2019-01-15T23:08:17Z

 dshape = (1, 3, 512, 512)
 dtype = "float32"
 target = "llvm"
 ctx = tvm.cpu()


Maybe better to use ctx_list to make it more generalized.

kevinthesun · 2019-01-18T21:24:34Z

@tqchen I added pip3 install gluoncv to Dockerfile.ci_gpu and Dockerfile.demo_gpu, but still can't import gluoncv. Is anywhere I missed?

tqchen · 2019-01-18T23:58:12Z

To make sure we cache the image correctly without repetitive rebuilds. The docker image does not rebuild automatically, please send a separate PR to update the docker file, and I will update the docker image.

kevinthesun · 2019-01-27T03:31:46Z

@tqchen Docker image not updated yet?

tqchen · 2019-01-27T03:49:40Z

Working on the docker now.

tqchen · 2019-01-28T05:06:59Z

Please check if the new ci error has things to do with this PR

kevinthesun · 2019-01-28T05:44:51Z

I just ran this test 10000 times locally but didn't get any failure. I'll re-trigger the ci to see what's the problem.

tqchen · 2019-01-28T18:01:08Z

The CI is now green, but please comment on the flaky case, to see if that could due to random-ness and tie (similar to argmax) or it is something that we can ignore

tqchen · 2019-03-11T18:42:07Z

Thanks, @kevinthesun @were @vinx13 @Laurawly this is now merged

kevinthesun mentioned this pull request Jan 1, 2019

[RFC][Hybrid Script] Syntax sugars for Hybrid Script #2262

Closed

icemelon added the status: WIP label Jan 4, 2019

kevinthesun force-pushed the RefactorSSDOperator branch from a7f1766 to 7f2712f Compare January 8, 2019 01:46

This was referenced Jan 11, 2019

[TOPI][CUDA] Add faster-rcnn proposal op #2420

Merged

[OP] SSD gluon-cv model support #1269

Closed

kevinthesun force-pushed the RefactorSSDOperator branch from 7ef52f3 to 81bb789 Compare January 13, 2019 19:21

kevinthesun changed the title ~~[WIP][Object Detection] Gluoncv SSD support on CPU~~ [Object Detection] Gluoncv SSD support on CPU Jan 14, 2019

kevinthesun force-pushed the RefactorSSDOperator branch 2 times, most recently from c1a4876 to fbe61e9 Compare January 15, 2019 00:44

vinx13 requested changes Jan 15, 2019

View reviewed changes

kevinthesun force-pushed the RefactorSSDOperator branch 2 times, most recently from 0b243b8 to 36250a6 Compare January 15, 2019 18:10

Laurawly requested changes Jan 15, 2019

View reviewed changes

kevinthesun force-pushed the RefactorSSDOperator branch from 8b12d06 to 9bf0c06 Compare January 18, 2019 19:55

Laurawly approved these changes Jan 22, 2019

View reviewed changes

were approved these changes Jan 22, 2019

View reviewed changes

kevinthesun force-pushed the RefactorSSDOperator branch 2 times, most recently from 81413f2 to 7eb53da Compare January 22, 2019 23:59

vinx13 approved these changes Jan 23, 2019

View reviewed changes

kevinthesun force-pushed the RefactorSSDOperator branch from 7eb53da to 88a7325 Compare January 23, 2019 21:15

kevinthesun force-pushed the RefactorSSDOperator branch from 88a7325 to 1544aab Compare January 28, 2019 05:39

Wang and others added 19 commits March 10, 2019 22:51

Fix test get_valid_counts numpy result

e7df94c

Rename ssd tutorial

45b6aac

Fix rebase

26ece34

Refactor nms

2f8aef8

Rollback nnvm

d30be86

Refactor relay nms

6b1fd7a

Add max_output_size arg

42571cf

Make return_indices optional

f8fecec

Minor fix

11c8bba

Resolve conflict

908eedb

Rename topk to top_k

9743f15

Fix example code

4bd6fec

Fix lint

d1e95f9

Minor fix

292130d

Remove contrib_slice_axis

fb94ffe

Resolve conflict

5c0cee9

Address minor comments

28d479a

Move tutorial

c2e02e4

Resolve conflict

d20024c

kevinthesun force-pushed the RefactorSSDOperator branch from 99556f4 to d20024c Compare March 11, 2019 05:55

tqchen approved these changes Mar 11, 2019

View reviewed changes

tqchen merged commit d2f29ba into apache:master Mar 11, 2019

tqchen added status: accepted and removed status: need update need update based on feedbacks labels Mar 11, 2019

wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019

[Object Detection] Gluoncv SSD support on CPU (apache#2353)

5aa6faa

Laurawly mentioned this pull request Mar 12, 2019

[Relay][TOPI] Gluncv SSD support on the GPU #2784

Merged

wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 12, 2019

[Object Detection] Gluoncv SSD support on CPU (apache#2353)

7726031

kevinthesun deleted the RefactorSSDOperator branch May 28, 2019 23:20

tqchen mentioned this pull request Nov 8, 2019

[RELEASE][DRAFT] TVM v0.6 Release candidate #4259

Closed

Conversation

kevinthesun commented Dec 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kevinthesun commented Jan 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinx13 Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

kevinthesun commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Laurawly Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

kevinthesun Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

Laurawly Jan 17, 2019

Choose a reason for hiding this comment

Uh oh!

Laurawly Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

kevinthesun Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

Laurawly Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

kevinthesun commented Jan 18, 2019

Uh oh!

tqchen commented Jan 18, 2019

Uh oh!

kevinthesun commented Jan 27, 2019

Uh oh!

tqchen commented Jan 27, 2019

Uh oh!

tqchen commented Jan 28, 2019

Uh oh!

kevinthesun commented Jan 28, 2019

Uh oh!

tqchen commented Jan 28, 2019

Uh oh!

tqchen commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kevinthesun commented Dec 29, 2018 •

edited

Loading

kevinthesun commented Jan 14, 2019 •

edited

Loading

kevinthesun commented Jan 15, 2019 •

edited

Loading

tqchen commented Mar 11, 2019 •

edited

Loading