Skip to content

STORM-3693: Pending tuples expired only once per tick. #3338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chandan83 wants to merge 1 commit into from
Closed

STORM-3693: Pending tuples expired only once per tick. #3338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions storm-client/src/jvm/org/apache/storm/executor/Executor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,18 @@ public void accept(Object event) {
int taskId = addressedTuple.getDest();

TupleImpl tuple = (TupleImpl) addressedTuple.getTuple();
String streamId = tuple.getSourceStreamId();
boolean isSpout = this instanceof SpoutExecutor;
if (isDebug) {
LOG.info("Processing received TUPLE: {} for TASK: {} ", tuple, taskId);
}

try {
if (taskId != AddressedTuple.BROADCAST_DEST) {
tupleActionFn(taskId, tuple);
} else if (isSpout && streamId.equals(Constants.SYSTEM_TICK_STREAM_ID)) {
//taskId is irrelevant here. Ensures pending.rotate() is called once per tick.
tupleActionFn(taskIds.get(0), tuple);
} else {
for (Integer t : taskIds) {
tupleActionFn(t, tuple);
Expand Down