STORM-3693: Pending tuples expired only once per tick.

[Chandan83]

What is the purpose of the change

(To ensure spout pending tuples are expired only once per tick. Otherwise, tuples get expired prematurely when one spout executor has multiple tasks.)

How was the change tested

(1. mvn clean install -P '!examples,!externals' 2. Used a dummy topology to test the correct behavior.)

[Chandan83]

@nathanmarz I am wondering if I can do something more to garner some attention to this PR. The fix seems to address a fundamental bug related to tuple expiry.

[rzo1]

@reiabreu wdyt about this?

[reiabreu]

@rzo1 I'm not familiar with this code. Let me have a look and report back.

[reiabreu]

@rzo1 @Chandan83
Had a look at the PR and it seems to be something we should fix. I would be more comfortable with some unit tests covering this, but we seem to be lacking specific tests for SpoutExecutor.

[reiabreu]

@rzo1 since the source branch is quite outdated, I can create a new PR with the diff applied to it and check the test pipelines.

[rzo1]

Let's do that. Thanks @reiabreu

[reiabreu]

I did not find the time for this yet, but I plan on opening a PR for this over the coming days. Cheers

[reiabreu]

Changes were moved to #3828 to have Github Actions validate the changes.
Thanks for the PR @Chandan83 !

[Chandan83]

Thanks @reiabreu <https://github.com/reiabreu>. Let me know if you need any help on it. BTW, I have changed projects since the PR was raised.

…

On Mon, Jan 13, 2025 at 3:02 PM reiabreu ***@***.***> wrote: Changes were moved to #3828 <#3828> to have Github Actions validate the changes. Thanks for the PR @Chandan83 <https://github.com/Chandan83> ! — Reply to this email directly, view it on GitHub <#3338 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH7LKFZHNCMKDSWNOWQSOT2KOB2DAVCNFSM6AAAAABTXYQFHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBWGYYDGMRWGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>