Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

no such method => modified function args #16610

Merged
marcoabreu merged 3 commits into from
Oct 30, 2019
Merged

no such method => modified function args #16610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d25d752
no such method => modified function args
phinzphinz Oct 24, 2019
b9f8db0
julia could not build package before
phinzphinz Oct 25, 2019
a01a9ee
Update julia/src/metric.jl
phinzphinz Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion julia/deps/build.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if Sys.isunix()
nvcc_path = Sys.which("nvcc")
if nvcc_path ≢ nothing
@info "Found nvcc: $nvcc_path"
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc", "lib64"))
push!(CUDAPATHS, replace(nvcc_path, "bin/nvcc" => "lib64"))
Copy link
Copy Markdown
Member

@iblislin iblislin Oct 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I have a PR that fixed the building issues #16125

Copy link
Copy Markdown
Contributor Author

@phinzphinz phinzphinz Oct 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Then this PR can be ignored.

Copy link
Copy Markdown
Member

@iblislin iblislin Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 ... we still can get this merged into master first.

end
end

Expand Down
2 changes: 1 addition & 1 deletion julia/src/metric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ end

function get(metric::MSE)
# Delay copy until last possible moment
mse_sum = mapreduce(nda->copy(nda)[1], +, 0.0, metric.mse_sum)
mse_sum = mapreduce(nda->copy(nda)[1], +, metric.mse_sum; init = zero(MX_float))
[(:MSE, mse_sum / metric.n_sample)]
end

Expand Down