Conversation
The original build process triggered by `Pkg.add` is done by GNU make.
The original build process triggered by `Pkg.add` is done by GNU make.
iblislin
force-pushed
the
ib/jl-cmake-build
branch
from
3ef9cf0 to
b28b847
Compare
| OpenBLAS | ||
| ) | ||
|
|
||
| # Check ILP64 data model for the case of Julia self-shipped `libopenblas64_.so` |
There was a problem hiding this comment.
Could anyone review this cmake script?
There was a problem hiding this comment.
I don't know much, but maybe you can simplify a bit using CHECK_SOURCE_COMPILES and similar. https://gitlab.kitware.com/cmake/community/wikis/doc/tutorials/How-To-Write-Platform-Checks
Overall looks ok-ish to me.
There was a problem hiding this comment.
ah, looks greate, I will try
-
CHECK_SYMBOL_EXISTS
There was a problem hiding this comment.
sorry, I'm swamped... I will try it after 1/10.
… into ib/jl-cmake-build
iblislin
changed the title
iblislin
changed the title
|
I think this PR is ready for review. |
|
@aaronmarkham This PR improves the integration of Julia's self-shipped I want to add a new build pipeline in the job |
I'm not sure. Let me socialize this a bit and someone can get back to you, but maybe not until after the holiday... |
ChaiBapchya
left a comment
ChaiBapchya
left a comment
There was a problem hiding this comment.
Have few suggestions/questions. Apologies if any of those are wrong/unintelligent. I don't quite understand cmake/julia but curious nonetheless.
| # We have do eagerly delete the build stuffs. | ||
| # Otherwise we won't rebuild on an update. | ||
| run(`rm -f $_libdir/libmxnet.$(Libdl.dlext)`) | ||
| rm(_blddir, recursive=true, force=true) |
There was a problem hiding this comment.
Previously it deleted the file libmxnet.* in the libdir
Now we are deleting the entire build directory. What changed with that?
There was a problem hiding this comment.
well, the final result is the same -- making a fresh build, not increamental build.
This build script is simliar to Python's setup.py.
It's for creating fresh build for user.
| run(download_cmd(package_url, "mxnet.7z")) | ||
| # this command will create the dir "usr\\lib" | ||
| run(`$exe7z e mxnet.7z *\\build\\* *\\lib\\* -y -ousr\\lib`) | ||
| run(`$exe7z e mxnet.7z "*\\build\\*" "*\\lib\\*" -y -ousr\\lib`) # TODO check it works on windows or not |
There was a problem hiding this comment.
Does this imply we "might" break cmake build for windows? Can't we check this on windows before merging PR?
There was a problem hiding this comment.
ah, I checked it on Window, but forgot to remove the comment.
The previous code just poped some warning about quoting.
Co-Authored-By: Chaitanya Prakash Bapat <chai.bapat@gmail.com>
4 participants
The original build process triggered by
Pkg.buildisdone by GNU make.
TODO
libopenblas, andINTERFACE64issue