You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit refactors two common error messages reported by the CSV reader to be clearer, more concise, and less redundant. This improves log readability and helps users diagnose data loading issues more efficiently.
Column Count Mismatch Error:
The previous error was excessively verbose, printing a large data buffer. It is now a single, direct line stating the problem with the expected vs. actual counts and a truncated sample.
Before: actual column number in csv file is more than schema column number.actual number: 19, schema column number: 18; ... result values:[...VERY LONG DATA DUMP...]
After: Column count mismatch: expected 18, but found 19 (sep:| delim:\n). Src line: 57|2023-08-19|TRUE|...
Invalid File Encoding Error:
The error for non-UTF-8 files was repetitive. It is now a single, direct statement of the requirement.
Before: Unable to display, only support csv data in utf8 codec, please check the data encoding
After: Invalid file encoding: all CSV files must be UTF-8 encoded
Release note
None
Check List (For Author)
Test
Regression test
Unit Test
Manual test (add detailed scripts or steps below)
No need to test or manual test. Explain why:
This is a refactor/code format and no logic has been changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
approvedIndicates a PR has been approved by one committer.reviewed
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #25816
Problem Summary:
This commit refactors two common error messages reported by the CSV reader to be clearer, more concise, and less redundant. This improves log readability and helps users diagnose data loading issues more efficiently.
Column Count Mismatch Error:
The previous error was excessively verbose, printing a large data buffer. It is now a single, direct line stating the problem with the expected vs. actual counts and a truncated sample.
actual column number in csv file is more than schema column number.actual number: 19, schema column number: 18; ... result values:[...VERY LONG DATA DUMP...]Column count mismatch: expected 18, but found 19 (sep:| delim:\n). Src line: 57|2023-08-19|TRUE|...Invalid File Encoding Error:
The error for non-UTF-8 files was repetitive. It is now a single, direct statement of the requirement.
Unable to display, only support csv data in utf8 codec, please check the data encodingInvalid file encoding: all CSV files must be UTF-8 encodedRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)