[enhancement](CSV-reader) enhance err log for CSV reading containing enclose or escape#25816
Merged
dataroaring merged 1 commit intoapache:masterfrom Oct 24, 2023
Merged
Conversation
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Hastyshell
force-pushed
the
csv-line-values-err-log
branch
from
1253fa6 to
86c5b3a
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
dataroaring
requested changes
Oct 24, 2023
Contributor
dataroaring
left a comment
dataroaring
left a comment
There was a problem hiding this comment.
Please add case for error message.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Oct 26, 2023
…enclose or escape (apache#25816)
Hastyshell
added a commit
to Hastyshell/doris
that referenced
this pull request
Oct 26, 2023
…enclose or escape (apache#25816)
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Oct 28, 2023
…enclose or escape (apache#25816)
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Oct 31, 2023
…enclose or escape (apache#25816)
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Nov 1, 2023
…enclose or escape (apache#25816)
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
…enclose or escape (apache#25816)
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…enclose or escape (apache#25816)
16 tasks
liaoxin01
pushed a commit
that referenced
this pull request
Sep 12, 2025
### What problem does this PR solve? Related PR: #25816 Problem Summary: This commit refactors two common error messages reported by the CSV reader to be clearer, more concise, and less redundant. This improves log readability and helps users diagnose data loading issues more efficiently. 1. **Column Count Mismatch Error:** The previous error was excessively verbose, printing a large data buffer. It is now a single, direct line stating the problem with the expected vs. actual counts and a truncated sample. * **Before:** `actual column number in csv file is more than schema column number.actual number: 19, schema column number: 18; ... result values:[...VERY LONG DATA DUMP...]` * **After:** `Column count mismatch: expected 18, but found 19 (sep:| delim:\n). Src line: 57|2023-08-19|TRUE|...` 2. **Invalid File Encoding Error:** The error for non-UTF-8 files was repetitive. It is now a single, direct statement of the requirement. * **Before:** `Unable to display, only support csv data in utf8 codec, please check the data encoding` * **After:** `Invalid file encoding: all CSV files must be UTF-8 encoded`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...