Skip to content

branch-3.1: [fix](group commit) replay wal set cloud cluster name (#51517)#52011

Merged
morrySnow merged 1 commit intoapache:branch-3.1from
mymeiyi:3.1-pick-51517
Jun 20, 2025
Merged

branch-3.1: [fix](group commit) replay wal set cloud cluster name (#51517)#52011
morrySnow merged 1 commit intoapache:branch-3.1from
mymeiyi:3.1-pick-51517

Conversation

@mymeiyi
Copy link
Copy Markdown
Contributor

@mymeiyi mymeiyi commented Jun 20, 2025

pick #51517

before apache#37157, replay wal select be
by the input `backend_id`.
after, should set cloud cluster name of `backend_id`. if not, fe wil use
default cluster and replay wal may fail because of `No Alive backends`
@mymeiyi mymeiyi requested a review from morrySnow as a code owner June 20, 2025 02:35
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Copy Markdown
Contributor Author

mymeiyi commented Jun 20, 2025

run buildall

@mymeiyi mymeiyi changed the title [fix](group commit) replay wal set cloud cluster name (#51517) branch-3.1: [fix](group commit) replay wal set cloud cluster name (#51517) Jun 20, 2025
@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 39926 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 083301ecd9c2c0b39b855557de8b9e8387253d0e, data reload: false

------ Round 1 ----------------------------------
q1	17826	7103	6587	6587
q2	2066	166	153	153
q3	10565	1101	1099	1099
q4	10215	761	692	692
q5	7948	2906	2862	2862
q6	221	141	141	141
q7	984	629	604	604
q8	10359	1986	2072	1986
q9	6785	6520	6525	6520
q10	7877	2237	2278	2237
q11	459	254	255	254
q12	396	214	212	212
q13	17785	2975	3010	2975
q14	232	209	222	209
q15	499	477	470	470
q16	506	389	369	369
q17	982	579	568	568
q18	7342	6684	6676	6676
q19	1387	1107	992	992
q20	464	204	194	194
q21	3928	3142	3173	3142
q22	1099	984	994	984
Total cold run time: 109925 ms
Total hot run time: 39926 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6625	6532	6559	6532
q2	330	231	237	231
q3	2901	2816	2976	2816
q4	2057	1821	1768	1768
q5	5742	5683	5659	5659
q6	204	127	127	127
q7	2146	1774	1813	1774
q8	3325	3497	3513	3497
q9	8748	8856	8831	8831
q10	3588	3507	3523	3507
q11	597	484	507	484
q12	807	607	589	589
q13	6341	3138	3150	3138
q14	288	284	255	255
q15	510	470	451	451
q16	481	427	433	427
q17	1844	1630	1605	1605
q18	8207	7759	7585	7585
q19	1742	1637	1664	1637
q20	2082	1848	1832	1832
q21	5159	4811	4816	4811
q22	1098	1007	992	992
Total cold run time: 64822 ms
Total hot run time: 58548 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 188875 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 083301ecd9c2c0b39b855557de8b9e8387253d0e, data reload: false

query1	973	373	369	369
query2	6512	1952	1980	1952
query3	6700	215	218	215
query4	34302	23403	23319	23319
query5	4353	470	422	422
query6	270	182	175	175
query7	4621	319	308	308
query8	277	209	213	209
query9	9645	2601	2591	2591
query10	482	271	278	271
query11	18057	15208	15184	15184
query12	158	107	99	99
query13	1636	431	412	412
query14	8824	6584	6654	6584
query15	230	172	178	172
query16	8041	491	481	481
query17	1638	585	566	566
query18	2112	307	316	307
query19	220	161	155	155
query20	113	105	105	105
query21	211	104	103	103
query22	4389	4160	4087	4087
query23	34043	33608	33354	33354
query24	12957	2849	2944	2849
query25	698	381	392	381
query26	1877	162	164	162
query27	3133	337	337	337
query28	7796	2106	2097	2097
query29	1061	444	426	426
query30	328	170	157	157
query31	993	800	809	800
query32	93	56	59	56
query33	793	287	287	287
query34	1024	496	521	496
query35	861	721	697	697
query36	1066	965	958	958
query37	285	69	69	69
query38	3952	3779	3802	3779
query39	1501	1383	1439	1383
query40	286	96	99	96
query41	51	54	50	50
query42	112	102	103	102
query43	540	478	492	478
query44	1279	814	819	814
query45	184	167	167	167
query46	1148	732	723	723
query47	1931	1826	1804	1804
query48	457	390	414	390
query49	1295	380	389	380
query50	834	414	410	410
query51	7264	7157	7025	7025
query52	99	93	93	93
query53	258	186	188	186
query54	1158	474	454	454
query55	82	78	77	77
query56	267	243	244	243
query57	1269	1189	1160	1160
query58	246	209	219	209
query59	3239	2933	2938	2933
query60	285	244	261	244
query61	115	110	107	107
query62	912	684	683	683
query63	235	190	193	190
query64	5272	647	620	620
query65	3310	3176	3169	3169
query66	1427	312	299	299
query67	15892	15408	15494	15408
query68	3539	615	588	588
query69	423	268	266	266
query70	1225	1133	1095	1095
query71	321	247	254	247
query72	6009	4022	3751	3751
query73	749	348	358	348
query74	10079	8751	9338	8751
query75	3351	2665	2655	2655
query76	1969	1087	1051	1051
query77	437	272	271	271
query78	10390	9566	9594	9566
query79	1094	619	615	615
query80	810	435	429	429
query81	483	223	218	218
query82	1271	90	88	88
query83	234	149	151	149
query84	238	79	81	79
query85	1094	307	286	286
query86	322	301	296	296
query87	4328	4206	4172	4172
query88	3156	2391	2366	2366
query89	414	306	294	294
query90	2073	191	192	191
query91	189	150	149	149
query92	58	51	51	51
query93	1061	569	562	562
query94	822	298	291	291
query95	359	255	250	250
query96	607	284	296	284
query97	3310	3144	3123	3123
query98	212	195	191	191
query99	1478	1329	1314	1314
Total cold run time: 297777 ms
Total hot run time: 188875 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 30.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 083301ecd9c2c0b39b855557de8b9e8387253d0e, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.22	0.07	0.07
query4	1.63	0.10	0.10
query5	0.53	0.51	0.53
query6	1.13	0.73	0.73
query7	0.02	0.02	0.03
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.57	0.54	0.53
query11	0.14	0.10	0.11
query12	0.14	0.10	0.11
query13	0.61	0.59	0.59
query14	0.76	0.80	0.82
query15	0.84	0.82	0.82
query16	0.37	0.37	0.39
query17	1.04	1.06	1.01
query18	0.24	0.22	0.22
query19	1.99	1.83	1.80
query20	0.02	0.00	0.01
query21	15.41	0.60	0.59
query22	2.29	1.87	1.92
query23	16.97	1.05	0.72
query24	3.12	1.75	1.19
query25	0.28	0.11	0.04
query26	0.52	0.14	0.13
query27	0.05	0.05	0.05
query28	9.62	0.52	0.46
query29	12.60	3.22	3.18
query30	0.24	0.06	0.07
query31	2.86	0.38	0.39
query32	3.24	0.46	0.46
query33	2.93	3.00	3.02
query34	16.93	4.50	4.54
query35	4.55	4.55	4.49
query36	0.67	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.15	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.69 s
Total hot run time: 30.26 s

@morrySnow
Copy link
Copy Markdown
Contributor

run external

@morrySnow morrySnow merged commit bef86ea into apache:branch-3.1 Jun 20, 2025
23 of 25 checks passed
@mymeiyi mymeiyi deleted the 3.1-pick-51517 branch September 10, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants