[fix](group commit) replay wal set cloud cluster name by mymeiyi · Pull Request #51517 · apache/doris

mymeiyi · 2025-06-05T06:57:40Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

before #37157, replay wal select be by the input backend_id.
after, should set cloud cluster name of backend_id. if not, fe wil use default cluster and replay wal may fail because of No Alive backends

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-06-05T06:57:45Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

mymeiyi · 2025-06-05T07:03:02Z

run buildall

doris-robot · 2025-06-05T08:34:02Z

TPC-H: Total hot run time: 33891 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ae1df906c2bc7bc1eba97a1397dddf1e2a7a190, data reload: false

------ Round 1 ----------------------------------
q1	26033	5029	5009	5009
q2	1954	283	174	174
q3	10416	1270	704	704
q4	10226	996	517	517
q5	7685	2370	2343	2343
q6	181	166	137	137
q7	903	736	635	635
q8	9317	1264	1039	1039
q9	6733	5104	5069	5069
q10	6875	2306	1891	1891
q11	493	298	288	288
q12	347	355	222	222
q13	17811	3669	3122	3122
q14	233	229	210	210
q15	571	496	508	496
q16	426	433	380	380
q17	600	862	357	357
q18	7639	7317	7150	7150
q19	1559	947	577	577
q20	329	342	228	228
q21	3669	3219	2375	2375
q22	1074	1038	968	968
Total cold run time: 115074 ms
Total hot run time: 33891 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5124	5032	5037	5032
q2	231	312	221	221
q3	2209	2707	2272	2272
q4	1359	1771	1343	1343
q5	4524	4408	4389	4389
q6	217	164	135	135
q7	2021	1913	1774	1774
q8	2614	2667	2569	2569
q9	7212	7140	6860	6860
q10	3028	3257	2768	2768
q11	585	506	512	506
q12	697	790	618	618
q13	3455	3901	3318	3318
q14	288	306	288	288
q15	500	482	477	477
q16	464	491	458	458
q17	1160	1558	1314	1314
q18	7780	7546	7404	7404
q19	802	820	894	820
q20	2005	2046	1945	1945
q21	4746	4428	4406	4406
q22	1122	1084	1041	1041
Total cold run time: 52143 ms
Total hot run time: 49958 ms

doris-robot · 2025-06-05T08:46:18Z

TPC-DS: Total hot run time: 193579 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ae1df906c2bc7bc1eba97a1397dddf1e2a7a190, data reload: false

query1	1446	1078	1063	1063
query2	6361	1785	1766	1766
query3	11124	4631	4487	4487
query4	55070	25137	23650	23650
query5	5125	544	481	481
query6	368	216	201	201
query7	4919	550	291	291
query8	291	233	215	215
query9	6118	2679	2708	2679
query10	443	344	281	281
query11	15024	15017	15172	15017
query12	169	116	112	112
query13	1080	530	434	434
query14	10093	6496	6434	6434
query15	210	219	184	184
query16	7122	663	508	508
query17	1082	752	604	604
query18	1595	411	308	308
query19	206	188	168	168
query20	138	136	117	117
query21	207	124	106	106
query22	4411	4544	4319	4319
query23	34319	33456	33566	33456
query24	6766	2424	2449	2424
query25	463	492	430	430
query26	723	271	155	155
query27	2512	517	352	352
query28	2989	2173	2179	2173
query29	571	564	427	427
query30	264	224	196	196
query31	824	859	772	772
query32	71	62	70	62
query33	451	374	313	313
query34	801	874	549	549
query35	829	867	774	774
query36	962	1003	908	908
query37	126	101	79	79
query38	4227	4230	4220	4220
query39	1573	1439	1473	1439
query40	213	128	111	111
query41	61	55	57	55
query42	127	116	120	116
query43	510	523	478	478
query44	1382	887	872	872
query45	186	184	170	170
query46	880	1058	677	677
query47	1838	1840	1796	1796
query48	410	450	335	335
query49	659	493	421	421
query50	706	723	423	423
query51	4339	4223	4259	4223
query52	114	117	105	105
query53	245	269	186	186
query54	605	595	517	517
query55	87	86	87	86
query56	307	291	306	291
query57	1189	1232	1124	1124
query58	269	266	260	260
query59	2628	2764	2771	2764
query60	329	339	333	333
query61	160	151	180	151
query62	751	763	697	697
query63	251	202	200	200
query64	1853	1024	683	683
query65	4231	4141	4130	4130
query66	729	405	309	309
query67	15829	15607	15407	15407
query68	7162	901	521	521
query69	548	312	270	270
query70	1210	1142	1094	1094
query71	512	315	314	314
query72	5733	4742	4849	4742
query73	1396	647	358	358
query74	8908	9265	8959	8959
query75	3872	3201	2688	2688
query76	4243	1210	774	774
query77	633	379	298	298
query78	10136	10046	9336	9336
query79	2114	833	572	572
query80	591	531	431	431
query81	554	265	221	221
query82	445	124	98	98
query83	256	248	238	238
query84	292	129	84	84
query85	805	350	326	326
query86	383	306	275	275
query87	4419	4407	4316	4316
query88	3540	2317	2275	2275
query89	417	312	293	293
query90	1827	215	215	215
query91	140	145	110	110
query92	80	60	55	55
query93	1762	969	587	587
query94	660	413	299	299
query95	360	294	286	286
query96	501	576	280	280
query97	2735	2790	2707	2707
query98	236	211	203	203
query99	1394	1406	1280	1280
Total cold run time: 299825 ms
Total hot run time: 193579 ms

hello-stephen · 2025-06-05T08:48:27Z

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2025-06-05T08:51:27Z

ClickBench: Total hot run time: 29.69 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2ae1df906c2bc7bc1eba97a1397dddf1e2a7a190, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.20
query5	0.45	0.44	0.45
query6	1.15	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.51	0.51
query10	0.57	0.58	0.56
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.78	0.81	0.80
query15	0.87	0.86	0.88
query16	0.41	0.38	0.37
query17	1.00	1.00	1.06
query18	0.22	0.21	0.21
query19	1.95	1.89	1.84
query20	0.01	0.01	0.01
query21	15.53	0.90	0.57
query22	0.75	1.19	0.72
query23	14.83	1.37	0.65
query24	6.79	1.23	1.13
query25	0.48	0.30	0.06
query26	0.48	0.16	0.15
query27	0.05	0.05	0.04
query28	9.39	0.92	0.45
query29	12.53	3.95	3.34
query30	0.25	0.09	0.06
query31	2.82	0.60	0.40
query32	3.22	0.56	0.48
query33	3.06	3.12	3.11
query34	15.91	5.12	4.55
query35	4.50	4.54	4.52
query36	0.67	0.52	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 102.74 s
Total hot run time: 29.69 s

mymeiyi · 2025-06-05T11:39:29Z

run buildall

doris-robot · 2025-06-05T12:04:25Z

TPC-H: Total hot run time: 33872 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 559c014151c60de0e2b00ef3bb62c94b144a4052, data reload: false

------ Round 1 ----------------------------------
q1	26158	4990	4960	4960
q2	1942	278	188	188
q3	10282	1269	681	681
q4	10224	1001	527	527
q5	7538	2398	2368	2368
q6	175	163	142	142
q7	900	804	612	612
q8	9398	1282	1114	1114
q9	6856	5114	5085	5085
q10	6824	2299	1923	1923
q11	494	297	276	276
q12	333	344	214	214
q13	17793	3717	3106	3106
q14	237	241	208	208
q15	580	488	470	470
q16	438	423	374	374
q17	601	857	374	374
q18	7683	7236	7122	7122
q19	1588	961	553	553
q20	332	334	225	225
q21	3739	3171	2343	2343
q22	1019	1049	1007	1007
Total cold run time: 115134 ms
Total hot run time: 33872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5032	4997	5009	4997
q2	244	314	220	220
q3	2158	2671	2267	2267
q4	1344	1975	1411	1411
q5	4515	4424	4446	4424
q6	219	172	126	126
q7	1981	1919	1749	1749
q8	2567	2402	2462	2402
q9	7141	7127	7123	7123
q10	2992	3181	2729	2729
q11	572	491	488	488
q12	649	733	632	632
q13	3457	3866	3307	3307
q14	270	297	286	286
q15	535	480	491	480
q16	437	490	430	430
q17	1121	1573	1350	1350
q18	7716	7565	7299	7299
q19	781	788	969	788
q20	2023	2035	1868	1868
q21	4939	4323	4357	4323
q22	1118	1026	1021	1021
Total cold run time: 51811 ms
Total hot run time: 49720 ms

doris-robot · 2025-06-05T12:15:58Z

TPC-DS: Total hot run time: 186060 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 559c014151c60de0e2b00ef3bb62c94b144a4052, data reload: false

query1	1009	479	508	479
query2	6570	1858	1809	1809
query3	6757	229	235	229
query4	25783	23420	23041	23041
query5	4339	620	498	498
query6	282	209	185	185
query7	4613	486	300	300
query8	266	219	209	209
query9	8636	2655	2682	2655
query10	493	329	278	278
query11	15280	15266	14908	14908
query12	160	111	107	107
query13	1664	533	436	436
query14	8731	6235	6319	6235
query15	205	195	175	175
query16	7150	662	488	488
query17	1174	750	611	611
query18	1995	437	315	315
query19	198	195	168	168
query20	122	117	119	117
query21	218	136	113	113
query22	4146	4152	4054	4054
query23	34154	33089	33130	33089
query24	8474	2448	2458	2448
query25	534	445	406	406
query26	1243	269	147	147
query27	2774	506	344	344
query28	4309	2150	2133	2133
query29	826	550	443	443
query30	288	224	188	188
query31	911	877	794	794
query32	70	66	62	62
query33	576	361	312	312
query34	809	845	536	536
query35	777	814	731	731
query36	944	989	891	891
query37	115	104	75	75
query38	4121	4111	4067	4067
query39	1467	1451	1381	1381
query40	214	119	108	108
query41	62	59	57	57
query42	132	113	104	104
query43	501	486	471	471
query44	1339	843	841	841
query45	185	177	172	172
query46	850	1025	625	625
query47	1743	1822	1703	1703
query48	378	451	316	316
query49	740	498	406	406
query50	665	674	412	412
query51	4134	4108	4083	4083
query52	116	112	104	104
query53	226	254	186	186
query54	572	568	520	520
query55	84	89	89	89
query56	303	298	302	298
query57	1141	1146	1092	1092
query58	272	274	257	257
query59	2599	2685	2627	2627
query60	337	327	318	318
query61	140	126	119	119
query62	829	743	633	633
query63	229	197	193	193
query64	4435	1014	680	680
query65	4265	4190	4144	4144
query66	1164	419	318	318
query67	15696	15596	15376	15376
query68	8290	898	531	531
query69	486	311	266	266
query70	1198	1175	1098	1098
query71	478	326	315	315
query72	5644	4848	4921	4848
query73	750	712	358	358
query74	9028	9046	8628	8628
query75	3896	3204	2721	2721
query76	3753	1194	768	768
query77	783	380	289	289
query78	10065	10244	9334	9334
query79	2423	801	583	583
query80	645	522	445	445
query81	467	259	218	218
query82	447	128	98	98
query83	294	264	232	232
query84	300	116	89	89
query85	769	360	320	320
query86	374	303	303	303
query87	4408	4371	4326	4326
query88	3268	2299	2315	2299
query89	383	317	285	285
query90	1913	213	211	211
query91	147	143	112	112
query92	79	66	59	59
query93	1737	936	587	587
query94	667	441	310	310
query95	378	291	293	291
query96	494	585	290	290
query97	2698	2759	2630	2630
query98	228	218	210	210
query99	1428	1394	1297	1297
Total cold run time: 273452 ms
Total hot run time: 186060 ms

doris-robot · 2025-06-05T12:21:13Z

ClickBench: Total hot run time: 28.83 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 559c014151c60de0e2b00ef3bb62c94b144a4052, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.12
query3	0.26	0.20	0.21
query4	1.59	0.21	0.10
query5	0.46	0.42	0.43
query6	1.16	0.67	0.66
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.53	0.53
query10	0.58	0.57	0.56
query11	0.15	0.11	0.11
query12	0.16	0.12	0.12
query13	0.61	0.59	0.60
query14	0.79	0.79	0.81
query15	0.89	0.87	0.86
query16	0.38	0.39	0.38
query17	1.06	1.06	1.08
query18	0.23	0.22	0.20
query19	1.90	1.79	1.90
query20	0.01	0.02	0.01
query21	15.40	0.87	0.56
query22	0.77	1.19	0.62
query23	14.93	1.36	0.63
query24	6.93	1.92	0.53
query25	0.47	0.08	0.09
query26	0.59	0.19	0.15
query27	0.06	0.05	0.05
query28	9.34	0.92	0.46
query29	12.54	3.99	3.36
query30	0.26	0.09	0.07
query31	2.84	0.59	0.39
query32	3.24	0.55	0.47
query33	3.01	3.08	3.02
query34	15.83	5.21	4.55
query35	4.58	4.52	4.54
query36	0.66	0.51	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.01 s
Total hot run time: 28.83 s

hello-stephen · 2025-06-05T13:32:12Z

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

dataroaring

LGTM

github-actions · 2025-06-09T06:07:16Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-06-09T06:07:18Z

PR approved by anyone and no changes requested.

koarz

LGTM

before apache#37157, replay wal select be by the input `backend_id`. after, should set cloud cluster name of `backend_id`. if not, fe wil use default cluster and replay wal may fail because of `No Alive backends`

apache#51517)

#51517) (#51666) pick #51517

before apache#37157, replay wal select be by the input `backend_id`. after, should set cloud cluster name of `backend_id`. if not, fe wil use default cluster and replay wal may fail because of `No Alive backends`

(#52011) Cherry-pick from #51517

…pache#4260) pick apache#51517

[fix](group commit) fix replay wal cloud cluster name

2ae1df9

fix case

559c014

dataroaring approved these changes Jun 9, 2025

View reviewed changes

github-actions Bot added the approved Indicates a PR has been approved by one committer. label Jun 9, 2025

github-actions Bot added the reviewed label Jun 9, 2025

koarz approved these changes Jun 9, 2025

View reviewed changes

dataroaring merged commit acf4b13 into apache:master Jun 9, 2025
25 of 26 checks passed

dataroaring added dev/3.0.x p0_b labels Jun 9, 2025

github-actions Bot added the dev/3.0.x-conflict label Jun 9, 2025

mymeiyi mentioned this pull request Jun 12, 2025

branch-3.0: Pick [fix](group commit) replay wal set cloud cluster name (#51517) #51666

Merged

mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jun 12, 2025

branch-3.0: Pick [fix](group commit) replay wal set cloud cluster name (

f6dd9b7

apache#51517)

dataroaring pushed a commit that referenced this pull request Jun 17, 2025

branch-3.0: Pick [fix](group commit) replay wal set cloud cluster name (

1b67a32

#51517) (#51666) pick #51517

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jun 17, 2025

dataroaring added the usercase Important user case type label label Jun 17, 2025

morrySnow added dev/3.1.x and removed dev/3.1.x labels Jun 19, 2025

github-actions Bot added the dev/3.1.x-conflict label Jun 19, 2025

mymeiyi mentioned this pull request Jun 20, 2025

branch-3.1: [fix](group commit) replay wal set cloud cluster name (#51517) #52011

Merged

morrySnow pushed a commit that referenced this pull request Jun 20, 2025

branch-3.1: [fix](group commit) replay wal set cloud cluster name #51517

bef86ea

(#52011) Cherry-pick from #51517

morrySnow added dev/3.1.0-merged and removed dev/3.1.x dev/3.1.x-conflict labels Jun 20, 2025

BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 1, 2025

[fix](group commit) replay wal set cloud cluster name (apache#51517) (a…

328e712

…pache#4260) pick apache#51517

Conversation

mymeiyi commented Jun 5, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Jun 5, 2025

Uh oh!

mymeiyi commented Jun 5, 2025

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

hello-stephen commented Jun 5, 2025

FE UT Coverage Report

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

mymeiyi commented Jun 5, 2025

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

doris-robot commented Jun 5, 2025

Uh oh!

hello-stephen commented Jun 5, 2025

FE UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

github-actions Bot commented Jun 9, 2025

Uh oh!

koarz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants