Skip to content

[opt](brpc) check and remove unavailable brpc stubs (#43212)#44840

Closed
mrhhsg wants to merge 1 commit intoapache:branch-3.0from
mrhhsg:pick_brpc
Closed

[opt](brpc) check and remove unavailable brpc stubs (#43212)#44840
mrhhsg wants to merge 1 commit intoapache:branch-3.0from
mrhhsg:pick_brpc

Conversation

@mrhhsg
Copy link
Copy Markdown
Member

@mrhhsg mrhhsg commented Dec 2, 2024

What problem does this PR solve?

pick #43212 , #44047 and #44481

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Dec 2, 2024

run buildall

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Dec 2, 2024

run buildall

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor

run external

@zhiqiang-hhhh
Copy link
Copy Markdown
Contributor

run p0

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Dec 17, 2024

run buildall

1 similar comment
@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Dec 17, 2024

run buildall

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Mar 20, 2025

run buildall

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Mar 20, 2025

run buildall

@doris-robot
Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 9.28% (9/97) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10171/26160)
Line Coverage 30.30% (86761/286346)
Region Coverage 29.34% (44568/151890)
Branch Coverage 25.86% (22670/87650)

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Mar 24, 2025

run buildall

@doris-robot
Copy link
Copy Markdown

TPC-H: Total hot run time: 40258 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 285b09b9f4ce315832344f878a96b2b9e4b2c63b, data reload: false

------ Round 1 ----------------------------------
q1	17583	6794	6634	6634
q2	2082	179	183	179
q3	10584	1095	1128	1095
q4	10527	769	730	730
q5	7813	2870	2879	2870
q6	223	132	128	128
q7	978	632	606	606
q8	9353	1942	2003	1942
q9	6611	6406	6382	6382
q10	7005	2258	2265	2258
q11	472	271	257	257
q12	395	214	200	200
q13	17805	2974	2964	2964
q14	237	208	211	208
q15	498	473	465	465
q16	657	589	592	589
q17	981	650	566	566
q18	7379	6796	6713	6713
q19	1404	1093	1058	1058
q20	482	204	193	193
q21	3987	3230	3256	3230
q22	1104	991	999	991
Total cold run time: 108160 ms
Total hot run time: 40258 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6607	6520	6517	6517
q2	333	240	224	224
q3	2893	2769	2933	2769
q4	2049	1790	1805	1790
q5	5736	5799	5730	5730
q6	208	127	128	127
q7	2237	1830	1806	1806
q8	3381	3544	3558	3544
q9	8631	8800	8871	8800
q10	3580	3494	3516	3494
q11	588	500	488	488
q12	808	594	588	588
q13	9586	3225	3111	3111
q14	303	272	274	272
q15	510	485	464	464
q16	701	672	651	651
q17	1853	1633	1584	1584
q18	8250	7848	7770	7770
q19	1654	1531	1502	1502
q20	2135	1873	1898	1873
q21	5570	5269	5210	5210
q22	1100	1051	1048	1048
Total cold run time: 68713 ms
Total hot run time: 59362 ms

@doris-robot
Copy link
Copy Markdown

TPC-DS: Total hot run time: 197370 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 285b09b9f4ce315832344f878a96b2b9e4b2c63b, data reload: false

query1	1290	894	891	891
query2	6242	2111	2060	2060
query3	10816	4298	4386	4298
query4	61366	28518	23257	23257
query5	5204	459	441	441
query6	406	167	175	167
query7	5483	309	303	303
query8	300	214	205	205
query9	8731	2590	2558	2558
query10	459	280	246	246
query11	17544	15377	15665	15377
query12	164	107	104	104
query13	1472	440	424	424
query14	9911	7465	7130	7130
query15	193	178	172	172
query16	7009	518	465	465
query17	1193	567	550	550
query18	1867	338	307	307
query19	220	152	159	152
query20	120	114	115	114
query21	205	103	103	103
query22	4949	4544	4880	4544
query23	34334	34333	34007	34007
query24	6184	2959	2879	2879
query25	536	443	415	415
query26	664	163	163	163
query27	1984	346	356	346
query28	4259	2433	2399	2399
query29	685	429	449	429
query30	238	162	159	159
query31	994	808	843	808
query32	65	53	60	53
query33	452	302	297	297
query34	900	498	503	498
query35	838	747	765	747
query36	1099	990	963	963
query37	116	62	68	62
query38	4105	4046	4180	4046
query39	1687	1453	1500	1453
query40	195	96	99	96
query41	51	46	48	46
query42	112	101	104	101
query43	532	498	494	494
query44	1129	802	803	802
query45	183	178	165	165
query46	1150	737	755	737
query47	2062	1941	1985	1941
query48	485	410	403	403
query49	746	396	437	396
query50	874	432	414	414
query51	7248	7306	7163	7163
query52	101	89	89	89
query53	258	188	183	183
query54	563	466	460	460
query55	78	72	74	72
query56	256	258	254	254
query57	1297	1198	1151	1151
query58	209	214	221	214
query59	3399	3188	2848	2848
query60	286	262	249	249
query61	107	107	104	104
query62	760	681	672	672
query63	213	184	186	184
query64	1387	663	645	645
query65	3282	3204	3196	3196
query66	718	322	319	319
query67	15985	15821	15766	15766
query68	3861	614	560	560
query69	430	280	268	268
query70	1176	1133	1159	1133
query71	368	269	255	255
query72	6525	4448	4092	4092
query73	737	358	353	353
query74	10214	9210	9019	9019
query75	3369	2643	2684	2643
query76	2004	1074	1075	1074
query77	481	311	279	279
query78	10665	9660	9602	9602
query79	2220	600	596	596
query80	1399	422	410	410
query81	535	241	237	237
query82	1184	90	88	88
query83	273	143	146	143
query84	285	88	75	75
query85	1028	303	283	283
query86	388	306	297	297
query87	4473	4229	4267	4229
query88	3770	2329	2292	2292
query89	416	291	289	289
query90	2002	182	183	182
query91	180	148	150	148
query92	61	48	49	48
query93	2653	539	538	538
query94	778	293	298	293
query95	360	252	254	252
query96	615	279	277	277
query97	3347	3170	3197	3170
query98	212	203	202	202
query99	1565	1287	1289	1287
Total cold run time: 315524 ms
Total hot run time: 197370 ms

@doris-robot
Copy link
Copy Markdown

ClickBench: Total hot run time: 32.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 285b09b9f4ce315832344f878a96b2b9e4b2c63b, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.53	0.50	0.53
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.57	0.56	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	2.87	2.75	2.75
query15	0.90	0.81	0.82
query16	0.38	0.39	0.38
query17	1.05	1.05	1.00
query18	0.23	0.22	0.21
query19	1.85	1.88	2.00
query20	0.01	0.01	0.02
query21	15.35	0.58	0.56
query22	2.88	1.81	1.92
query23	17.04	0.98	0.80
query24	2.93	1.44	1.28
query25	0.29	0.28	0.04
query26	0.40	0.13	0.12
query27	0.04	0.04	0.04
query28	9.86	0.53	0.47
query29	12.53	3.31	3.32
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.26	0.46	0.45
query33	2.98	3.05	3.05
query34	16.93	4.58	4.45
query35	4.53	4.56	4.58
query36	0.70	0.49	0.49
query37	0.09	0.06	0.05
query38	0.04	0.04	0.04
query39	0.04	0.02	0.03
query40	0.17	0.13	0.14
query41	0.09	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.34 s
Total hot run time: 32.6 s

@github-actions
Copy link
Copy Markdown
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Sep 21, 2025
@github-actions github-actions bot closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants