Skip to content

[opt](brpc) Make the timeout of brpc checking configurable#44481

Merged
yiguolei merged 2 commits intoapache:masterfrom
mrhhsg:opt_brpc_check
Nov 26, 2024
Merged

[opt](brpc) Make the timeout of brpc checking configurable#44481
yiguolei merged 2 commits intoapache:masterfrom
mrhhsg:opt_brpc_check

Conversation

@mrhhsg
Copy link
Copy Markdown
Member

@mrhhsg mrhhsg commented Nov 22, 2024

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 22, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 22, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 22, 2024

TPC-H: Total hot run time: 40063 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0dd1317a458c2b5a119ffe96f89119b68b460a31, data reload: false

------ Round 1 ----------------------------------
q1	17698	7649	7330	7330
q2	2054	184	178	178
q3	10637	1102	1149	1102
q4	10392	741	732	732
q5	7597	2765	2762	2762
q6	237	149	148	148
q7	995	615	593	593
q8	9246	1853	1906	1853
q9	6611	6423	6471	6423
q10	6993	2305	2377	2305
q11	479	264	266	264
q12	422	221	212	212
q13	17784	2997	3066	2997
q14	239	224	216	216
q15	566	531	528	528
q16	674	590	612	590
q17	991	492	488	488
q18	7375	6700	6737	6700
q19	1343	980	957	957
q20	454	185	181	181
q21	4098	3185	3207	3185
q22	365	322	319	319
Total cold run time: 107250 ms
Total hot run time: 40063 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7295	7302	7257	7257
q2	333	232	237	232
q3	2944	2839	2950	2839
q4	2078	1767	1820	1767
q5	5740	5736	5724	5724
q6	224	140	141	140
q7	2304	1814	1789	1789
q8	3430	3609	3524	3524
q9	9020	8940	8905	8905
q10	3631	3540	3598	3540
q11	595	516	525	516
q12	861	633	618	618
q13	11374	3283	3261	3261
q14	301	270	268	268
q15	575	516	531	516
q16	685	635	650	635
q17	1912	1627	1626	1626
q18	8374	7740	7681	7681
q19	1700	1623	1630	1623
q20	2160	1882	1869	1869
q21	5658	5463	5463	5463
q22	634	580	596	580
Total cold run time: 71828 ms
Total hot run time: 60373 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 22, 2024

TeamCity be ut coverage result:
Function Coverage: 38.31% (9978/26047)
Line Coverage: 29.42% (83495/283814)
Region Coverage: 28.57% (42963/150353)
Branch Coverage: 25.17% (21830/86742)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0dd1317a458c2b5a119ffe96f89119b68b460a31_0dd1317a458c2b5a119ffe96f89119b68b460a31/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 22, 2024

TPC-DS: Total hot run time: 198605 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0dd1317a458c2b5a119ffe96f89119b68b460a31, data reload: false

query1	1259	949	943	943
query2	6256	2131	2122	2122
query3	10918	4233	4097	4097
query4	68672	28796	23539	23539
query5	4933	504	480	480
query6	420	212	187	187
query7	5563	302	298	298
query8	338	243	246	243
query9	8601	2802	2792	2792
query10	457	271	265	265
query11	17360	15433	15839	15433
query12	162	107	120	107
query13	1500	430	430	430
query14	11097	7428	7533	7428
query15	218	196	224	196
query16	7604	431	540	431
query17	1096	617	578	578
query18	1930	305	310	305
query19	213	152	153	152
query20	123	114	115	114
query21	202	103	103	103
query22	4855	4533	4706	4533
query23	35214	34672	34395	34395
query24	5665	2496	2568	2496
query25	494	412	417	412
query26	682	153	151	151
query27	1871	294	295	294
query28	4303	2524	2465	2465
query29	670	426	431	426
query30	216	154	155	154
query31	1009	843	857	843
query32	67	61	56	56
query33	400	298	289	289
query34	949	531	536	531
query35	852	757	729	729
query36	1080	962	983	962
query37	134	93	84	84
query38	4484	4500	4516	4500
query39	1534	1512	1579	1512
query40	210	101	102	101
query41	48	43	45	43
query42	117	98	101	98
query43	540	515	516	515
query44	1230	823	839	823
query45	190	177	176	176
query46	1158	757	722	722
query47	2035	1901	1944	1901
query48	434	326	330	326
query49	736	406	397	397
query50	873	403	427	403
query51	7439	7172	7124	7124
query52	98	85	91	85
query53	256	187	179	179
query54	510	414	406	406
query55	74	76	78	76
query56	248	234	272	234
query57	1311	1181	1171	1171
query58	218	212	214	212
query59	3199	3070	3028	3028
query60	270	239	247	239
query61	107	106	108	106
query62	796	676	681	676
query63	221	192	195	192
query64	1402	669	645	645
query65	3316	3253	3268	3253
query66	622	300	318	300
query67	16032	15716	15653	15653
query68	4223	573	573	573
query69	413	269	271	269
query70	1205	1179	1125	1125
query71	337	251	261	251
query72	6499	4067	4083	4067
query73	771	369	372	369
query74	10224	9089	9097	9089
query75	3458	2689	2717	2689
query76	1809	1025	1056	1025
query77	485	276	284	276
query78	10555	9455	9453	9453
query79	1615	601	602	601
query80	965	439	439	439
query81	502	235	232	232
query82	1308	121	119	119
query83	271	156	155	155
query84	279	76	72	72
query85	887	309	302	302
query86	362	311	293	293
query87	4897	4645	4605	4605
query88	3603	2279	2255	2255
query89	428	305	300	300
query90	1885	193	231	193
query91	136	105	108	105
query92	67	52	52	52
query93	1916	554	548	548
query94	737	285	289	285
query95	352	252	254	252
query96	613	289	282	282
query97	2873	2716	2666	2666
query98	215	195	198	195
query99	1759	1310	1309	1309
Total cold run time: 322740 ms
Total hot run time: 198605 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 22, 2024

ClickBench: Total hot run time: 33.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0dd1317a458c2b5a119ffe96f89119b68b460a31, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.04
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.41	0.41	0.43
query6	1.16	0.68	0.66
query7	0.02	0.02	0.02
query8	0.04	0.02	0.04
query9	0.58	0.51	0.49
query10	0.56	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.61
query14	2.84	2.84	2.84
query15	0.91	0.83	0.83
query16	0.39	0.38	0.36
query17	0.99	1.01	0.98
query18	0.24	0.21	0.21
query19	1.89	1.85	2.04
query20	0.01	0.01	0.01
query21	15.37	0.60	0.60
query22	2.51	2.37	2.03
query23	17.05	0.88	0.88
query24	3.08	1.87	2.21
query25	0.35	0.17	0.14
query26	0.52	0.14	0.14
query27	0.04	0.04	0.04
query28	9.10	1.09	1.06
query29	12.55	3.25	3.17
query30	0.24	0.06	0.06
query31	2.87	0.38	0.36
query32	3.30	0.47	0.48
query33	2.99	3.02	3.01
query34	17.06	4.45	4.47
query35	4.57	4.52	4.55
query36	0.69	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.12	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.67 s
Total hot run time: 33.87 s

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 23, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 23, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 23, 2024

TPC-H: Total hot run time: 39912 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cee0e5b57587859254db57965ee8e37e9e50923a, data reload: false

------ Round 1 ----------------------------------
q1	17680	7635	7397	7397
q2	2058	182	173	173
q3	10639	1136	1220	1136
q4	10582	734	685	685
q5	7631	2739	2658	2658
q6	252	147	145	145
q7	964	633	598	598
q8	9225	1894	1968	1894
q9	6650	6423	6386	6386
q10	6992	2296	2326	2296
q11	454	249	252	249
q12	422	212	216	212
q13	17786	3156	3014	3014
q14	259	208	216	208
q15	579	546	519	519
q16	633	590	575	575
q17	984	682	491	491
q18	7465	6820	6725	6725
q19	1346	964	1020	964
q20	472	176	187	176
q21	4021	3209	3099	3099
q22	378	324	312	312
Total cold run time: 107472 ms
Total hot run time: 39912 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7273	7258	7253	7253
q2	330	230	234	230
q3	2904	2820	2881	2820
q4	2099	1861	1902	1861
q5	5695	5707	5657	5657
q6	223	142	149	142
q7	2253	1795	1799	1795
q8	3479	3556	3501	3501
q9	8763	8961	8959	8959
q10	3632	3566	3584	3566
q11	607	514	498	498
q12	804	623	628	623
q13	10267	3234	3265	3234
q14	300	275	265	265
q15	577	541	533	533
q16	690	659	642	642
q17	1869	1650	1622	1622
q18	8420	7820	7541	7541
q19	2109	1628	1524	1524
q20	2147	1890	1886	1886
q21	5373	5459	5372	5372
q22	620	570	546	546
Total cold run time: 70434 ms
Total hot run time: 60070 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 23, 2024

TPC-DS: Total hot run time: 197115 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cee0e5b57587859254db57965ee8e37e9e50923a, data reload: false

query1	1254	949	959	949
query2	6220	2172	2055	2055
query3	10835	3998	4031	3998
query4	67776	28350	23462	23462
query5	5057	453	454	453
query6	421	183	182	182
query7	5651	303	297	297
query8	319	230	228	228
query9	9459	2759	2768	2759
query10	457	258	242	242
query11	17341	15287	15784	15287
query12	151	99	99	99
query13	1549	411	434	411
query14	10376	7480	7567	7480
query15	204	179	190	179
query16	7113	500	464	464
query17	1135	564	558	558
query18	1843	304	301	301
query19	210	170	156	156
query20	119	113	109	109
query21	216	104	106	104
query22	4816	4635	4769	4635
query23	34723	34291	34320	34291
query24	5539	2477	2481	2477
query25	500	381	402	381
query26	665	152	153	152
query27	1869	292	292	292
query28	4524	2501	2495	2495
query29	702	453	431	431
query30	232	153	159	153
query31	1029	839	855	839
query32	68	59	59	59
query33	450	288	302	288
query34	935	514	513	513
query35	866	727	708	708
query36	1082	956	973	956
query37	123	80	73	73
query38	4413	4494	4444	4444
query39	1523	1468	1442	1442
query40	201	94	95	94
query41	43	41	49	41
query42	107	104	97	97
query43	534	529	505	505
query44	1192	835	834	834
query45	186	180	174	174
query46	1164	730	701	701
query47	2072	1935	1897	1897
query48	427	325	321	321
query49	726	398	397	397
query50	864	422	390	390
query51	7398	7285	7097	7097
query52	101	93	89	89
query53	254	178	173	173
query54	501	389	389	389
query55	79	73	83	73
query56	246	238	230	230
query57	1280	1176	1162	1162
query58	220	209	222	209
query59	3285	3107	2925	2925
query60	269	249	237	237
query61	107	104	105	104
query62	797	671	665	665
query63	219	189	182	182
query64	1366	670	699	670
query65	3288	3217	3186	3186
query66	722	307	323	307
query67	16073	15730	15607	15607
query68	3965	580	575	575
query69	431	264	317	264
query70	1220	1163	1146	1146
query71	354	252	240	240
query72	6422	4016	4015	4015
query73	763	365	367	365
query74	10257	9153	8978	8978
query75	3364	2797	2705	2705
query76	1793	1056	1087	1056
query77	483	277	280	277
query78	10463	9458	9351	9351
query79	2842	615	615	615
query80	1403	421	455	421
query81	532	238	228	228
query82	1148	117	120	117
query83	250	148	158	148
query84	278	80	68	68
query85	1029	294	292	292
query86	417	301	303	301
query87	4779	4504	4582	4504
query88	4072	2220	2209	2209
query89	426	289	291	289
query90	2007	183	185	183
query91	135	101	105	101
query92	71	47	49	47
query93	2840	532	544	532
query94	904	290	273	273
query95	347	243	248	243
query96	631	285	286	285
query97	2919	2684	2636	2636
query98	210	195	195	195
query99	1578	1298	1312	1298
Total cold run time: 323819 ms
Total hot run time: 197115 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 23, 2024

TeamCity be ut coverage result:
Function Coverage: 38.32% (9981/26049)
Line Coverage: 29.44% (83559/283829)
Region Coverage: 28.59% (42989/150360)
Branch Coverage: 25.18% (21845/86746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cee0e5b57587859254db57965ee8e37e9e50923a_cee0e5b57587859254db57965ee8e37e9e50923a/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 23, 2024

ClickBench: Total hot run time: 32.66 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cee0e5b57587859254db57965ee8e37e9e50923a, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.05	0.03
query3	0.24	0.08	0.06
query4	1.62	0.10	0.11
query5	0.42	0.41	0.42
query6	1.15	0.65	0.65
query7	0.01	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.53	0.50
query10	0.56	0.57	0.55
query11	0.14	0.10	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.71	2.81	2.83
query15	0.91	0.82	0.82
query16	0.37	0.38	0.39
query17	1.05	0.96	1.04
query18	0.22	0.21	0.22
query19	1.92	1.85	1.88
query20	0.01	0.02	0.01
query21	15.41	0.63	0.59
query22	2.51	1.87	2.40
query23	17.00	0.98	0.77
query24	2.98	2.11	1.05
query25	0.25	0.08	0.13
query26	0.54	0.14	0.14
query27	0.04	0.05	0.05
query28	9.86	1.10	1.07
query29	12.63	3.22	3.19
query30	0.25	0.06	0.06
query31	2.88	0.37	0.37
query32	3.27	0.46	0.46
query33	2.96	3.02	3.05
query34	16.97	4.45	4.48
query35	4.48	4.50	4.49
query36	0.66	0.48	0.48
query37	0.09	0.06	0.07
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 105.97 s
Total hot run time: 32.66 s

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 25, 2024
yiguolei
yiguolei previously approved these changes Nov 25, 2024
View reviewed changes
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2024

PR approved by anyone and no changes requested.

yiguolei
yiguolei reviewed Nov 25, 2024
View reviewed changes
Comment thread be/src/common/config.cpp Outdated
// Enable brpc connection check
DEFINE_Bool(enable_brpc_connection_check, "false");

DEFINE_mInt64(brpc_connection_check_timeout_ms, "1000");
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change default value to a larger timeout value, for example 10s

@mrhhsg
Copy link
Copy Markdown
Member Author

mrhhsg commented Nov 25, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 25, 2024

TPC-H: Total hot run time: 39876 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 29eccc670bcf0ab4cabafcd779f7eac3b4ed52ac, data reload: false

------ Round 1 ----------------------------------
q1	18021	7601	7260	7260
q2	2063	169	167	167
q3	10641	1136	1160	1136
q4	10312	749	697	697
q5	7629	2743	2719	2719
q6	241	153	144	144
q7	975	614	602	602
q8	9250	1819	1900	1819
q9	6670	6393	6391	6391
q10	6986	2268	2318	2268
q11	456	253	244	244
q12	427	214	214	214
q13	17815	3016	3041	3016
q14	259	220	221	220
q15	567	538	513	513
q16	656	572	604	572
q17	970	624	577	577
q18	7529	6765	6694	6694
q19	1334	1077	1035	1035
q20	475	178	181	178
q21	4134	3163	3095	3095
q22	386	315	319	315
Total cold run time: 107796 ms
Total hot run time: 39876 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7239	7242	7183	7183
q2	324	228	226	226
q3	2954	2812	3031	2812
q4	2103	1838	1762	1762
q5	5616	5695	5689	5689
q6	227	142	136	136
q7	2154	1753	1839	1753
q8	3380	3542	3485	3485
q9	8855	8845	8912	8845
q10	3582	3526	3520	3520
q11	607	514	514	514
q12	814	634	610	610
q13	10652	3261	3158	3158
q14	306	266	288	266
q15	573	517	540	517
q16	669	633	636	633
q17	1810	1585	1581	1581
q18	7881	7427	7360	7360
q19	1673	1557	1606	1557
q20	2055	1824	1810	1810
q21	5356	5212	5268	5212
q22	624	559	530	530
Total cold run time: 69454 ms
Total hot run time: 59159 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 25, 2024

TPC-DS: Total hot run time: 190564 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 29eccc670bcf0ab4cabafcd779f7eac3b4ed52ac, data reload: false

query1	963	380	393	380
query2	6541	2193	2073	2073
query3	6707	214	212	212
query4	34146	23667	23471	23471
query5	4386	461	452	452
query6	282	182	178	178
query7	4622	288	297	288
query8	300	225	223	223
query9	9518	2636	2622	2622
query10	482	257	246	246
query11	18117	15321	15146	15146
query12	150	101	103	101
query13	1668	416	412	412
query14	10258	7401	7365	7365
query15	290	180	174	174
query16	8176	429	439	429
query17	1799	554	532	532
query18	2130	293	293	293
query19	355	144	140	140
query20	119	113	114	113
query21	205	101	103	101
query22	4526	4427	4306	4306
query23	34886	33918	33963	33918
query24	10603	2397	2516	2397
query25	629	365	400	365
query26	1623	142	155	142
query27	2796	279	272	272
query28	8140	2424	2435	2424
query29	959	395	387	387
query30	298	180	148	148
query31	1063	805	810	805
query32	99	56	58	56
query33	781	282	270	270
query34	1017	495	506	495
query35	875	706	730	706
query36	1112	954	918	918
query37	126	73	74	73
query38	4347	4247	4148	4148
query39	1459	1413	1433	1413
query40	287	101	97	97
query41	50	44	45	44
query42	110	101	99	99
query43	534	512	497	497
query44	1229	788	802	788
query45	176	163	161	161
query46	1150	682	707	682
query47	1939	1859	1871	1859
query48	391	317	304	304
query49	1235	392	384	384
query50	823	375	400	375
query51	7221	7026	7199	7026
query52	95	93	89	89
query53	263	182	178	178
query54	1075	400	401	400
query55	78	83	76	76
query56	268	248	248	248
query57	1317	1173	1128	1128
query58	234	214	219	214
query59	3542	3133	3010	3010
query60	290	277	247	247
query61	116	110	105	105
query62	917	674	695	674
query63	209	188	179	179
query64	5044	638	625	625
query65	3277	3192	3225	3192
query66	1121	317	308	308
query67	16005	15683	15516	15516
query68	4997	548	527	527
query69	405	251	251	251
query70	1194	1051	1066	1051
query71	339	260	251	251
query72	6406	4121	4024	4024
query73	763	351	358	351
query74	10407	9009	9014	9009
query75	3400	2684	2694	2684
query76	3029	1080	1111	1080
query77	551	297	273	273
query78	10417	9447	9422	9422
query79	1511	595	679	595
query80	875	425	430	425
query81	540	238	226	226
query82	722	123	110	110
query83	271	153	143	143
query84	234	74	68	68
query85	1248	284	297	284
query86	350	290	300	290
query87	4585	4572	4527	4527
query88	3363	2182	2176	2176
query89	390	290	290	290
query90	2116	182	186	182
query91	133	105	103	103
query92	57	53	51	51
query93	1352	535	539	535
query94	1112	259	287	259
query95	358	243	241	241
query96	604	277	270	270
query97	2848	2694	2675	2675
query98	249	194	198	194
query99	1521	1305	1298	1298
Total cold run time: 301896 ms
Total hot run time: 190564 ms

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 25, 2024

TeamCity be ut coverage result:
Function Coverage: 38.31% (9980/26051)
Line Coverage: 29.44% (83556/283841)
Region Coverage: 28.59% (42993/150362)
Branch Coverage: 25.18% (21841/86746)
Coverage Report: http://coverage.selectdb-in.cc/coverage/29eccc670bcf0ab4cabafcd779f7eac3b4ed52ac_29eccc670bcf0ab4cabafcd779f7eac3b4ed52ac/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Nov 25, 2024

ClickBench: Total hot run time: 31.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 29eccc670bcf0ab4cabafcd779f7eac3b4ed52ac, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.22	0.07	0.08
query4	1.62	0.10	0.11
query5	0.44	0.40	0.41
query6	1.17	0.67	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.58	0.53	0.49
query10	0.54	0.55	0.54
query11	0.13	0.11	0.10
query12	0.14	0.12	0.11
query13	0.62	0.61	0.60
query14	2.86	2.84	2.74
query15	0.92	0.83	0.82
query16	0.37	0.39	0.38
query17	1.06	1.07	1.05
query18	0.23	0.21	0.21
query19	1.92	1.76	2.02
query20	0.01	0.01	0.01
query21	15.37	0.60	0.58
query22	2.63	1.84	1.52
query23	16.95	0.89	0.87
query24	3.44	1.36	0.51
query25	0.26	0.15	0.15
query26	0.41	0.13	0.13
query27	0.04	0.05	0.04
query28	10.85	1.10	1.09
query29	12.56	3.26	3.24
query30	0.25	0.06	0.05
query31	2.87	0.38	0.38
query32	3.28	0.46	0.46
query33	3.03	3.03	3.02
query34	16.88	4.51	4.45
query35	4.52	4.49	4.55
query36	0.68	0.49	0.48
query37	0.09	0.06	0.05
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.11
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 107.49 s
Total hot run time: 31.89 s

yiguolei
yiguolei approved these changes Nov 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 6ce0208 into apache:master Nov 26, 2024
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
@mrhhsg
[opt](brpc) Make the timeout of brpc checking configurable (#44481)
5666037
@github-actions github-actions bot mentioned this pull request Nov 26, 2024
Merged
yiguolei pushed a commit that referenced this pull request Nov 26, 2024
@github-actions @mrhhsg
branch-2.1: [opt](brpc) Make the timeout of brpc checking configurable …
071a210 
…#44481 (#44602)

Cherry-picked from #44481

Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
@mrhhsg mrhhsg deleted the opt_brpc_check branch December 2, 2024 03:09
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Dec 2, 2024
@mrhhsg
[opt](brpc) Make the timeout of brpc checking configurable (apache#44481
2ad8114 
)
@mrhhsg mrhhsg mentioned this pull request Dec 2, 2024
Closed
16 tasks
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Dec 2, 2024
@mrhhsg
[opt](brpc) Make the timeout of brpc checking configurable (apache#44481
6e5a8fa 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@jacktengg jacktengg jacktengg approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrhhsg @doris-robot @yiguolei @jacktengg