Skip to content

[Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks #36317#36536

Merged
xiaokang merged 1 commit intoapache:branch-2.1from
eldenmoon:var-sc
Jun 19, 2024
Merged

[Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks #36317#36536
xiaokang merged 1 commit intoapache:branch-2.1from
eldenmoon:var-sc

Conversation

@eldenmoon
Copy link
Copy Markdown
Member

@eldenmoon eldenmoon commented Jun 19, 2024

…ma and write missing blocks (#36317)

buffering block during schema change should merge first and then flush, otherwise may lost current block

Proposed changes

Issue Number: close #xxx

@eldenmoon
[Fix](Variant) fix variant schema change may cause invalid block sche…
c7c0797 
…ma and write missing blocks (apache#36317)

buffering block during schema change should merge first and then
flush, otherwise may lost current block
@doris-robot
Copy link
Copy Markdown

doris-robot commented Jun 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Copy Markdown
Member Author

eldenmoon commented Jun 19, 2024

run buildall

1 similar comment
@eldenmoon
Copy link
Copy Markdown
Member Author

eldenmoon commented Jun 19, 2024

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 19, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jun 19, 2024

TeamCity be ut coverage result:
Function Coverage: 36.30% (9133/25158)
Line Coverage: 27.79% (74259/267225)
Region Coverage: 26.72% (38311/143379)
Branch Coverage: 23.41% (19405/82896)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c7c07971af032bf6b91256a1a9af9afd1bad379d_c7c07971af032bf6b91256a1a9af9afd1bad379d/report/index.html

@doris-robot
Copy link
Copy Markdown

doris-robot commented Jun 19, 2024

TeamCity be ut coverage result:
Function Coverage: 36.30% (9133/25158)
Line Coverage: 27.79% (74261/267225)
Region Coverage: 26.73% (38321/143379)
Branch Coverage: 23.41% (19408/82896)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c7c07971af032bf6b91256a1a9af9afd1bad379d_c7c07971af032bf6b91256a1a9af9afd1bad379d/report/index.html

@xiaokang xiaokang changed the title [Fix](Variant) fix variant schema change may cause invalid block sche… [Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks #36317 Jun 19, 2024
@xiaokang xiaokang merged commit 0be5331 into apache:branch-2.1 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eldenmoon @doris-robot @xiaokang