[Fix](Variant) fix variant schema change may cause invalid block schema and write missing blocks#36317
Merged
xiaokang merged 2 commits intoapache:masterfrom Jun 19, 2024
Merged
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39534 ms |
TPC-DS: Total hot run time: 169487 ms |
ClickBench: Total hot run time: 31.49 s |
xiaokang
changed the title
…ma and write missing blocks 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
Member
Author
done |
Member
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39933 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 172576 ms |
ClickBench: Total hot run time: 30.43 s |
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jun 19, 2024
…ma and write missing blocks (apache#36317) buffering block during schema change should merge first and then flush, otherwise may lost current block
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
…ma and write missing blocks (#36317) 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Jul 10, 2024
…ma and write missing blocks (apache#36317) 1. update_rowset_schema should not update _context.tablet_schema, since it's used as src schema for schema change, if it's changed may lead to wrong schema with block 2. buffering block during schema change should merge first and then flush, otherwise may lost current block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ma and write missing blocks
Proposed changes
Issue Number: close #xxx