Skip to content

Revert "[fix](jdbc_catalog) fix error datetime literal caused be core (#34977)#35341

Merged
morrySnow merged 1 commit intoapache:branch-2.0from
morrySnow:revert_34977
May 24, 2024
Merged

Revert "[fix](jdbc_catalog) fix error datetime literal caused be core (#34977)#35341
morrySnow merged 1 commit intoapache:branch-2.0from
morrySnow:revert_34977

Conversation

@morrySnow
Copy link
Copy Markdown
Contributor

This reverts commit cddf62b.
This reverts PR #34977.

It introduce a behavior change, below case will failed after this PR

        CREATE TABLE `roles` (
            role_id       INT,
            occupation    VARCHAR(32),
            camp          VARCHAR(32),
            register_time DATE
        )
        UNIQUE KEY(role_id)
        PARTITION BY RANGE (role_id)
        (
            PARTITION p1 VALUES LESS THAN ("10")
        )
        DISTRIBUTED BY HASH(role_id) BUCKETS 1
        PROPERTIES (
            "replication_allocation" = "tag.location.default: 1",
            "binlog.enable" = "true"
        );

        INSERT INTO `roles` VALUES
        (0, 'who am I', NULL, NULL),
        (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
        (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
        (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
        (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
        (5, 'shaman', 'horde', NULL),
        (6, 'warrior', 'alliance', NULL),
        (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
        (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE

…apache#34977)"

This reverts commit cddf62b.

It introduce a behavior change, below case will failed after this PR

            CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );

            INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE
@doris-robot
Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Copy Markdown
Contributor Author

run buildall

@github-actions github-actions Bot added area/planner Issues or PRs related to the query planner kind/test labels May 24, 2024
@morrySnow morrySnow merged commit c6013c4 into apache:branch-2.0 May 24, 2024
@morrySnow morrySnow deleted the revert_34977 branch May 24, 2024 08:16
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…apache#34977)" (apache#35341)

This reverts commit cddf62b.
This reverts PR apache#34977.

It introduce a behavior change, below case will failed after this PR

            CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );

            INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner kind/test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants