Skip to content

[fix](jdbc_catalog) fix error datetime literal caused be core#34977

Merged
yiguolei merged 3 commits intoapache:branch-2.0from
Yulei-Yang:fix_jdbc_datetime_parse_exception_for_v2
May 17, 2024
Merged

[fix](jdbc_catalog) fix error datetime literal caused be core#34977
yiguolei merged 3 commits intoapache:branch-2.0from
Yulei-Yang:fix_jdbc_datetime_parse_exception_for_v2

Conversation

@Yulei-Yang
Copy link
Copy Markdown
Contributor

@Yulei-Yang Yulei-Yang commented May 16, 2024

Proposed changes

Issue Number: close #34975

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link
Copy Markdown

doris-robot commented May 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label May 16, 2024
@Yulei-Yang
Copy link
Copy Markdown
Contributor Author

Yulei-Yang commented May 16, 2024

run buildall

cambyzju
cambyzju approved these changes May 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 16, 2024

PR approved by anyone and no changes requested.

@Yulei-Yang
Copy link
Copy Markdown
Contributor Author

Yulei-Yang commented May 17, 2024

run buildall

@Yulei-Yang
Copy link
Copy Markdown
Contributor Author

Yulei-Yang commented May 17, 2024

run buildall

nextdreamblue
nextdreamblue approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nextdreamblue nextdreamblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit cddf62b into apache:branch-2.0 May 17, 2024
@Yulei-Yang Yulei-Yang deleted the fix_jdbc_datetime_parse_exception_for_v2 branch May 20, 2024 01:34
@morrySnow
Copy link
Copy Markdown
Contributor

morrySnow commented May 23, 2024

this PR introduce a behavior change, below case will failed after this PR

CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );


INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE

morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request May 24, 2024
@morrySnow
Revert "[fix](jdbc_catalog) fix error datetime literal caused be core (…
40c13bf 
…apache#34977)"

This reverts commit cddf62b.

It introduce a behavior change, below case will failed after this PR

            CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );

            INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE
@morrySnow morrySnow mentioned this pull request May 24, 2024
Merged
morrySnow added a commit that referenced this pull request May 24, 2024
@morrySnow
Revert "[fix](jdbc_catalog) fix error datetime literal caused be core (…
c6013c4 
…#34977)" (#35341)

This reverts commit cddf62b.
This reverts PR #34977.

It introduce a behavior change, below case will failed after this PR

            CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );

            INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@Yulei-Yang
[fix](jdbc_catalog) fix error datetime literal caused be core (apache…
3827b99 
…#34977)

* [fix](jdbc_catalog) fix error datetime literal caused be core

* fix error regression test

* fix regression test
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@morrySnow
Revert "[fix](jdbc_catalog) fix error datetime literal caused be core (…
8e18c87 
…apache#34977)" (apache#35341)

This reverts commit cddf62b.
This reverts PR apache#34977.

It introduce a behavior change, below case will failed after this PR

            CREATE TABLE `roles` (
                role_id       INT,
                occupation    VARCHAR(32),
                camp          VARCHAR(32),
                register_time DATE
            )
            UNIQUE KEY(role_id)
            PARTITION BY RANGE (role_id)
            (
                PARTITION p1 VALUES LESS THAN ("10")
            )
            DISTRIBUTED BY HASH(role_id) BUCKETS 1
            PROPERTIES (
                "replication_allocation" = "tag.location.default: 1",
                "binlog.enable" = "true"
            );

            INSERT INTO `roles` VALUES
            (0, 'who am I', NULL, NULL),
            (1, 'mage', 'alliance', '2018-12-03 16:11:28'),
            (2, 'paladin', 'alliance', '2018-11-30 16:11:28'),
            (3, 'rogue', 'horde', '2018-12-01 16:11:28'),
            (4, 'priest', 'alliance', '2018-12-02 16:11:28'),
            (5, 'shaman', 'horde', NULL),
            (6, 'warrior', 'alliance', NULL),
            (7, 'warlock', 'horde', '2018-12-04 16:11:28'),
            (8, 'hunter', 'horde', NULL);

the original plan is right. the bug should be fixed on BE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cambyzju cambyzju cambyzju approved these changes

@nextdreamblue nextdreamblue nextdreamblue approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner kind/behavior-changed kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Yulei-Yang @doris-robot @morrySnow @cambyzju @nextdreamblue @yiguolei