[fix](memory) Allocator address sanitizers enable print stack trace #33853
[fix](memory) Allocator address sanitizers enable print stack trace #33853xinyiZzz merged 1 commit intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
| DEFINE_mString(get_stack_trace_tool, "libunwind"); | ||
| DEFINE_mString(dwarf_location_info_mode, "FAST"); | ||
| DEFINE_mBool(enable_address_sanitizers_with_stack_trace, "false"); | ||
| DEFINE_mBool(enable_address_sanitizers_with_stack_trace, "true"); |
There was a problem hiding this comment.
not set to true by default
There was a problem hiding this comment.
only take effect under DEBUG
| static std::mutex stacktrace_cache_mutex; | ||
|
|
||
| std::string toStringCached(const StackTrace::FramePointers& pointers, size_t offset, size_t size) { | ||
| std::string toStringCached(const StackTrace::FramePointers& pointers, size_t offset, size_t size, |
There was a problem hiding this comment.
do not modify these very low API, it is very likely to import some bugs.
There was a problem hiding this comment.
i am 99.99% sure it's fine
xinyiZzz
force-pushed
the
20240417_fix_tracker_asan
branch
from
a7e071b to
c06238e
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38403 ms |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
… from default to 2048 since 50 may cause performance issue introduced by apache#33853
…pache#33853) Allocator address sanitizers enable dwarf_location_info_mode=DISABLED stack trace, this will no stack line numbers, maybe cause performance reduce 1x
… from default to 2048 (apache#34105) since 50 may cause performance issue introduced by apache#33853
4 participants
Proposed changes
Allocator address sanitizers enable
dwarf_location_info_mode=DISABLEDstack trace, this will no stack line numbers, maybe cause performance reduce 1xFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...