[enhancement](memory) Allocator support address sanitizers#33396
Merged
xinyiZzz merged 9 commits intoapache:masterfrom Apr 18, 2024
Merged
[enhancement](memory) Allocator support address sanitizers#33396xinyiZzz merged 9 commits intoapache:masterfrom
xinyiZzz merged 9 commits intoapache:masterfrom
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
run buildall |
2 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
xinyiZzz
force-pushed
the
20240407_fix_tracker0
branch
from
4c6f389 to
07b018f
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run p0 |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run p0 |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run p0 |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
xinyiZzz
force-pushed
the
20240407_fix_tracker0
branch
from
f4f5d96 to
e2057da
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
ClickBench: Total hot run time: 29.94 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 38752 ms |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38486 ms |
TPC-DS: Total hot run time: 185549 ms |
ClickBench: Total hot run time: 30.4 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
This was referenced Apr 18, 2024
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 9, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 9, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 10, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
yiguolei
pushed a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 10, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
yiguolei
pushed a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 11, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
xinyiZzz
added a commit
to xinyiZzz/incubator-doris
that referenced
this pull request
Sep 13, 2024
) If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace. add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query. If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
yiguolei
added a commit
that referenced
this pull request
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
If DEBUG build type, record size of each memory alloc and free, print no free size or no alloc size when query MemTracker is destructed, if necessary, record stack trace.
add global PointQueryExecutor memory tracker in ExecEnv, because memory may be shared between PointQueryExecutors of different pointer queries, but memory will not be shared between PointQueryExecutor and Fragment of the same pointer query.
If DEBUG build type, if query memory tracker not equal to 0 when query ends, BE will crash.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...