Skip to content

[branch-2.0-fix](partial update) only report error when in strict mode partial update when finding missing rowsets during flushing memtable#28739

Merged
xiaokang merged 1 commit intoapache:branch-2.0from
bobhan1:branch-2.0-only-report-error-in-partial-update
Dec 20, 2023
Merged

[branch-2.0-fix](partial update) only report error when in strict mode partial update when finding missing rowsets during flushing memtable#28739
xiaokang merged 1 commit intoapache:branch-2.0from
bobhan1:branch-2.0-only-report-error-in-partial-update

Conversation

@bobhan1
Copy link
Copy Markdown
Contributor

@bobhan1 bobhan1 commented Dec 20, 2023 •
edited
Loading

Proposed changes

fix #28679
pick from master: #28764

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Dec 20, 2023

run buildall

@bobhan1 bobhan1 force-pushed the branch-2.0-only-report-error-in-partial-update branch from e7b94f7 to 4041c9b Compare December 20, 2023 10:43
@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Dec 20, 2023

run buildall

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2023

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 20, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 20, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 20, 2023

TeamCity be ut coverage result:
Function Coverage: 37.79% (7991/21144)
Line Coverage: 29.50% (64918/220077)
Region Coverage: 28.97% (33404/115295)
Branch Coverage: 24.84% (17139/68986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4041c9b963bfecf7ef66fb60af0d98718c0cea46_4041c9b963bfecf7ef66fb60af0d98718c0cea46/report/index.html

zhannngchen
zhannngchen approved these changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobhan1
Copy link
Copy Markdown
Contributor Author

bobhan1 commented Dec 20, 2023

run clickbench

@doris-robot
Copy link
Copy Markdown

doris-robot commented Dec 20, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.91 seconds
stream load tsv: 568 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.9 seconds inserted 10000000 Rows, about 334K ops/s
storage size: 17164041860 Bytes

@xiaokang xiaokang merged commit 00a092d into apache:branch-2.0 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1 @doris-robot @zhannngchen @dataroaring @xiaokang