move array function unit_tests to sqllogictest

[Veeupup]

Which issue does this PR close?

Closes #8324 .

I have checked the unit tests in array_expressions.rs and found that almost all test cases are covered by sqllogictest.

So this PR is almost about removing the duplicate unit tests

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

[Veeupup]

cc @jayzhan211 @alamb PTAL

[alamb]

Thank you very much @Veeupup

[alamb]

Let me know if this looks good to you @jayzhan211

[jayzhan211]

LGTM!

@Veeupup Before closing #8324, how about function like test_align_array_dimensions?
We should either remove it or move it to dfcommon::utils if it is possible to be used elsewhere.

[Veeupup]

LGTM!

@Veeupup Before closing #8324, how about function like test_align_array_dimensions? We should either remove it or move it to dfcommon::utils if it is possible to be used elsewhere.

Sure! But I found that align_array_dimensions is only used in array_expressions.rs and its signature is not pub. So it would be fine to just keep in array_expressions.rs

[alamb]

Sure! But I found that align_array_dimensions is only used in array_expressions.rs and its signature is not pub. So it would be fine to just keep in array_expressions.rs

I agree this is a good plan (to keep align_array_dimensions test in array_expressions.rs

[jayzhan211]

OK, we can keep it. I am just afraid that people will create test in array_expression.rs if there is still rust test (any kind of test) inside it.

[Weijun-H]

OK, we can keep it. I am just afraid that people will create test in array_expression.rs if there is still rust test (any kind of test) inside it.

Maybe we should leave some comments for it 🤔

[jayzhan211]

OK, we can keep it. I am just afraid that people will create test in array_expression.rs if there is still rust test (any kind of test) inside it.

Maybe we should leave some comments for it 🤔

I think comments help.

[alamb]

Thank you @Veeupup @jayzhan211 and @Weijun-H