MINOR: Move simplify_expression rule to datafusion-optimizer crate#2686
Merged
andygrove merged 8 commits intoapache:masterfrom Jun 5, 2022
Merged
MINOR: Move simplify_expression rule to datafusion-optimizer crate#2686andygrove merged 8 commits intoapache:masterfrom
simplify_expression rule to datafusion-optimizer crate#2686andygrove merged 8 commits intoapache:masterfrom
Conversation
andygrove
changed the title
simplify_expression rule to datafusion-optimizer cratesimplify_expression rule to datafusion-optimizer crate
github-actions
Bot
added
core
andygrove
changed the title
simplify_expression rule to datafusion-optimizer cratesimplify_expression rule to datafusion-optimizer crate
Codecov Report
@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
- Coverage 84.66% 84.66% -0.01%
==========================================
Files 270 270
Lines 46919 46919
==========================================
- Hits 39726 39724 -2
- Misses 7193 7195 +2
Continue to review full report at Codecov.
|
andygrove
commented
Jun 4, 2022
| /// | ||
| /// Both arguments must be convertable into Strings (Into<String>) | ||
| #[macro_export] | ||
| macro_rules! assert_contains { |
Member
Author
There was a problem hiding this comment.
this is copy-and-pasted from the core crate
yjshen
approved these changes
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Builds on #2682
Rationale for this change
This is the final part of the refactoring to create the optimizer crate and moves the last rule over
What changes are included in this PR?
Are there any user-facing changes?
API change because the code moved.