Move physical expression planning to datafusion-physical-expr crate#2682
Merged
alamb merged 5 commits intoapache:masterfrom Jun 4, 2022
Merged
Move physical expression planning to datafusion-physical-expr crate#2682alamb merged 5 commits intoapache:masterfrom
datafusion-physical-expr crate#2682alamb merged 5 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2682 +/- ##
=======================================
Coverage 84.63% 84.64%
=======================================
Files 267 269 +2
Lines 46867 46926 +59
=======================================
+ Hits 39665 39719 +54
- Misses 7202 7207 +5
Continue to review full report at Codecov.
|
alamb
approved these changes
Jun 4, 2022
Contributor
alamb
left a comment
There was a problem hiding this comment.
I obviously didn't review this entire PR in detail but I checked that the tests remained intact and everything else looks good. Thank you @andygrove I really like how the modularization is proceeding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2535
Rationale for this change
The main motivation was to not have SimplifyExpressions depend on the core datafusion crate so that we can move it to the new
datafusion-optimizercrateWhat changes are included in this PR?
Move the following items from core to
datafusion-physical-expr:create_physical_exprExecutionPropsVarProviderScalarFunctionExprAre there any user-facing changes?
Not too much since I added re-exports but this is still an API change.