Changed clippy.toml and added std hashmap and hashset to disallowed t…#19872
Open
Phaneendra293 wants to merge 2 commits intoapache:mainfrom
Open
Changed clippy.toml and added std hashmap and hashset to disallowed t…#19872Phaneendra293 wants to merge 2 commits intoapache:mainfrom
Phaneendra293 wants to merge 2 commits intoapache:mainfrom
Conversation
Author
|
The changes have been completed and pushed. |
Contributor
|
Thanks for volunteering to pick up this issue; part of the expectation of the issue is to ensure CI passes, namely that clippy violations are fixed. Could you look into this please? |
Contributor
|
Looks like there are clippy failures now -- can you fix them @Phaneendra293 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Clippy configuration to disallow usage of std::collections::HashMap and std::collections::HashSet across the DataFusion codebase.
The change helps enforce consistent usage of project-preferred HashMap/set implementations, avoiding accidental use of the standard library types.
What changed
Updated clippy. toml to add std::collections::HashMap and std::collections::HashSet to the list of disallowed types.
Ensures new code follows the project’s hashing and performance conventions.
Why
The default Rust HashMap / HashSet use randomized hashing, which may be:
non-deterministic,
sub-optimal for performance-critical paths,
inconsistent with DataFusion’s existing design choices.
Enforcing this at the lint level prevents regressions and improves code consistency for contributors.
Testing
No functional code changes.
CI / Clippy will fail if std::HashMap or std::HashSet are newly introduced.